Packet ids not properly wired up to the TCP P2P socket. |
|||||
Issue descriptionThis causes problems in WebRTC calls over TCP, where bandwidth estimation fails, which can cause high loss rates and long delays.
,
Apr 25 2017
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dabbe072b786618bbc557381a0c535596c698822 commit dabbe072b786618bbc557381a0c535596c698822 Author: holmer <holmer@chromium.org> Date: Wed Apr 26 16:57:02 2017 Wire up rtc_packet_ids to P2PSocketHostTcp, which is required for correct BWE in WebRTC. BUG= chromium:715099 Review-Url: https://codereview.chromium.org/2841803003 Cr-Commit-Position: refs/heads/master@{#467349} [modify] https://crrev.com/dabbe072b786618bbc557381a0c535596c698822/content/browser/renderer_host/p2p/socket_host_tcp.cc [modify] https://crrev.com/dabbe072b786618bbc557381a0c535596c698822/content/browser/renderer_host/p2p/socket_host_tcp.h [modify] https://crrev.com/dabbe072b786618bbc557381a0c535596c698822/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc [modify] https://crrev.com/dabbe072b786618bbc557381a0c535596c698822/content/browser/renderer_host/p2p/socket_host_test_utils.h
,
Apr 26 2017
Verified that this fixed the issue in Chrome ToT.
,
Apr 27 2017
Verified that the fix works in Canary (60.0.3082.0), requesting merge to M59.
,
Apr 27 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a12e597b35058cd9028f2a339442bab3c5668194 commit a12e597b35058cd9028f2a339442bab3c5668194 Author: holmer <holmer@chromium.org> Date: Fri Apr 28 17:46:38 2017 Wire up rtc_packet_ids to P2PSocketHostTcp, which is required for correct BWE in WebRTC. BUG= chromium:715099 Review-Url: https://codereview.chromium.org/2841803003 Cr-Commit-Position: refs/heads/master@{#467349} (cherry picked from commit dabbe072b786618bbc557381a0c535596c698822) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2846243002 Cr-Commit-Position: refs/branch-heads/3071@{#297} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/a12e597b35058cd9028f2a339442bab3c5668194/content/browser/renderer_host/p2p/socket_host_tcp.cc [modify] https://crrev.com/a12e597b35058cd9028f2a339442bab3c5668194/content/browser/renderer_host/p2p/socket_host_tcp.h [modify] https://crrev.com/a12e597b35058cd9028f2a339442bab3c5668194/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc [modify] https://crrev.com/a12e597b35058cd9028f2a339442bab3c5668194/content/browser/renderer_host/p2p/socket_host_test_utils.h |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by roy...@google.com
, Apr 25 2017