New issue
Advanced search Search tips

Issue 715098 link

Starred by 3 users

Issue metadata

Status: Archived
Owner: ----
Closed: Nov 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

settings_override for search_provider triggers two permission checks

Reported by dominik....@ecosia.org, Apr 25 2017

Issue description

Chrome Version       : 59.0.3071.15
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1. Install an extension in chrome that doesn't use the settings_override API yet
2. Change that extension to use the settings_override API to change the default search 
3. Update the extension in chrome to the new version using the API

What is the expected result?
The extension updates without any notifications and the extension stays enabled. On the first search the user is asked if that is the search result they expected and are given the option to easily revert their default search.

What happens instead of that?
The extension is disabled with a notification the same way as if a new permission was requested. 

Please provide any additional information below. Attach a screenshot if
possible.

Using the settings_override API is handled as if a new permission is requested, which is called {"searchProvider":"www.test.com"} when you list your permissions afterwards. But requesting this as an optional_permission does not work. This means there is no way to introduce this API to an existing extension without it being disabled automatically on update. As there is already a safeguard for changing the default search by showing the user a popup on the first search I'm unsure that this is intended behavior, especially as this seems to not happen for the page_override API, which shows a similar popup.

This issues can repoduced on OSX and Windows for at least Chrome Version 58, 59 and 60.

I attached screenshots for the relevant notifications (sorry, they are mostly in German).

UserAgentString: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.15 Safari/537.36



 
needs permission1.png
26.3 KB View Download
needs permission2.png
25.7 KB View Download
new tab popup.png
22.3 KB View Download
search popup.png
25.1 KB View Download
Could this be updated to be in the Platform>Extension component? Maybe that way it would be more likely to be seen by the right people. Can't find a way to edit it myself, sorry.
Cc: pnangunoori@chromium.org
Labels: Needs-Feedback
@dominik.henter -- Thanks for posting this issue. Could you please provide sample extension to reproduce this issue. This would help us to triage the issue further.
Thanks @pnangunoori for getting back to me. This happens for every extension that uses the settings_override API to change the default search, so there are a lot of examples in the chrome extension store. You can find ours here: https://chrome.google.com/webstore/detail/ecosia-the-search-engine/eedlgdlajadkbbjoobobefphmfkcchfk
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 3 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "pnangunoori@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: Platform>Extensions
Labels: Needs-Milestone
Requesting Extensions Dev team to look into this issue.
Thanks!
Labels: TE-NeedsTriageHelp
The issue seems to be out of TE-scope as it is related to changing the extension to use the settings_override API to change the default search from unit level. Hence, adding label TE-NeedsTriageHelp for further investigation from dev team.

Thanks...!!
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 2

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
@krajshree@chromium.org I don't know how to reopen this, but this is still valid.

Sign in to add a comment