video attribute "disableremoteplayback" is not honored with Media Remoting |
||||||
Issue descriptionGoogle Chrome 60.0.3077.0 (Official Build) canary (64-bit) Platform 9483.0.0 (Official Build) canary-channel samus What steps will reproduce the problem? (0) Enable chrome://flags/#media-remoting flag (1) Go to https://beaufortfrancois.github.io/sandbox/media/remote-playback.html (2) Uncheck "Remote Playback" (3) Play video (4) Cast tab (5) Make video fullscreen What is the expected result? Media Remoting UX shouldn't launch as video explicitly stated "no remote playback allowed". What happens instead? Video plays fullscreen in Chromecast device.
,
Apr 25 2017
We were. It must have regressed. I'll take a look today, and also look into where our unit test coverage was lacking.
,
Apr 25 2017
xjz: Could you PTAL? I'm a bit slammed today.
,
Apr 25 2017
Sure. I'll take a look.
,
Apr 25 2017
Didn't repro locally on my linux workstation. Working as expected. When "Remote Playback" is unchecked and go to fullscreen, video is playing fullscreen on TV in mirroring mode. When "Remote Playback" is checked, video starts remoting when enters fullscreen.
,
Apr 25 2017
fbeaufort@: is the video "remoted" or simply playing fullscreen?
,
Apr 25 2017
I saw xjz@ use fbeaufort's demo page on a trunk Linux build. It was definitely remoting when the checkbox was checked, and not remoting when cleared. Could there possibly be anything different for CrOS w.r.t. how the Blink attributes are applied or propagated back to Chromium platform code (WMPI)?
,
Apr 25 2017
I'd wait for Francois to confirm he sees the media remoting UI in the media element :)
,
Apr 25 2017
avayvod: The screenshot in his post was the "remoting interstitial" view: https://plus.google.com/u/1/+FrancoisBeaufort/posts/bCAFwn7EQGi
,
Apr 26 2017
My bad! I was confused because I thought the fact the video doesn't go fullscreen when casting was part of the Media Remoting UI. When disableremoteplayback is there, I can see my mouse cursor in remote screen. Is there any reason why the "disableremoteplayback" video is not fullscreened in the tab while casting?
,
Apr 26 2017
By the way, it would be nice to make poster image darker so that user can read text as it is hard now as you can see in "without-disableremoteplayback.png" image attached above.
,
Apr 26 2017
fbeaufort@, this screenshot is indeed problematic. It is an a11y issue. Can you file a but and CC everyone here + bettes@?
,
Apr 26 2017
Yes, the contrast of the remoting interstitial with the background image needs to be enhanced. Filed the bug crbug.com/715641 . |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mlamouri@chromium.org
, Apr 25 2017Components: Internals>Cast
Owner: m...@chromium.org