DCHECK when trying to pay twice with the same credit card |
||||
Issue description1. In the Payment Request dialog, hit Pay 2. On the CVC unmask screen, hit the back arrow 3. Hit Pay again [38683:38683:0425/095644.426709:FATAL:autofill_payment_instrument.cc(50)] Check failed: !delegate_. #0 0x7fdc2c532f5b base::debug::StackTrace::StackTrace() #1 0x7fdc2c531c5c base::debug::StackTrace::StackTrace() #2 0x7fdc2c5a5373 logging::LogMessage::~LogMessage() #3 0x55f8c0c72575 payments::AutofillPaymentInstrument::InvokePaymentApp() #4 0x55f8bf8c3482 payments::PaymentResponseHelper::PaymentResponseHelper() #5 0x55f8bf8b9840 _ZN4base10MakeUniqueIN8payments21PaymentResponseHelperEJRKSsRPNS1_18PaymentRequestSpecERPNS1_17PaymentInstrumentERPNS1_22PaymentRequestDelegateERPN8autofill15AutofillProfileESH_PNS1_19PaymentRequestStateEEEENS_8internal16MakeUniqueResultIT_E6ScalarEDpOT0_ #6 0x55f8bf8b84e3 payments::PaymentRequestState::GeneratePaymentResponse() #7 0x55f8bf8acba4 payments::PaymentRequest::Pay() #8 0x55f8bf1e31ec payments::PaymentRequestDialogView::Pay() #9 0x55f8bf1e9d10 payments::PaymentRequestSheetController::ButtonPressed()
,
Apr 27 2017
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f72420b280a531f5db4d636b8f1ad57cf20c9895 commit f72420b280a531f5db4d636b8f1ad57cf20c9895 Author: mathp <mathp@chromium.org> Date: Thu Apr 27 19:13:17 2017 [Payments] Handle clicking back on the CVC unmask dialog Was previously crashing because the AutofillPaymentInstrument delegate was not being reset properly on back navigation. Now it is. BUG= 715093 TEST=browser_tests Review-Url: https://codereview.chromium.org/2844293002 Cr-Commit-Position: refs/heads/master@{#467747} [modify] https://crrev.com/f72420b280a531f5db4d636b8f1ad57cf20c9895/chrome/browser/ui/views/payments/cvc_unmask_view_controller.cc [modify] https://crrev.com/f72420b280a531f5db4d636b8f1ad57cf20c9895/chrome/browser/ui/views/payments/cvc_unmask_view_controller_browsertest.cc [modify] https://crrev.com/f72420b280a531f5db4d636b8f1ad57cf20c9895/components/payments/core/autofill_payment_instrument.cc
,
Apr 27 2017
,
Jun 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by anthonyvd@chromium.org
, Apr 25 2017Owner: ma...@chromium.org