Issue 715077 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	jdoerrie@chromium.org
Closed:	Jul 2017
Cc:	jochen@chromium.org █ mkwst@chromium.org █ zkoch@chromium.org kpaulhamus@chromium.org battre@chromium.org vasi...@chromium.org
Components:	Blink>SecurityFeature>CredentialManagement UI>Browser>Passwords
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Task

Blocked on:
issue 714615
issue 718416
issue 721399
issue 722242
issue 724464

Implement CM API spec changes required for merge with WebAuthn

Project Member Reported by jdoerrie@chromium.org, Apr 25 2017

Issue description

The WebAuthn API was rewritten in ttps://github.com/w3c/webauthn/pull/384 to extend the Credential Manager API. 

There were several minor changes required for the CM API to make this integration possible, which currently only exist in the specification.

The intent of this bug is to track progress towards implementing these changes.

The WebAuthn API was rewritten in https://github.com/w3c/webauthn/pull/384 to extend the Credential Manager API. 

There were several minor changes required for the CM API to make this integration possible, which currently only exist in the specification.

The intent of this bug is to track progress towards implementing these changes.

Comment 1 by jdoerrie@chromium.org, Apr 25 2017

Description: Show this description

Comment 2 by jochen@chromium.org, Apr 25 2017

Cc: kpaulhamus@chromium.org

Project Member

Comment 3 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb

commit 44ca0605b598508b94a2cf0ccb4d37b8023ef3fb
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue May 02 11:19:33 2017

Update CM API IDL to use SecureContext

This change implements recent changes to the Credential Manager API
specification that introduce the |SecureContext| extended attribute on
its interfaces. Furthermore it removes
|RuntimeEnabled=CredentialManager| from the interfaces following the
discussion in http://crrev.com/2832813002.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/-E-O9LgsPfM/ExJ7hiY1BQAJ

BUG= 715077 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2844453002
Cr-Commit-Position: refs/heads/master@{#468596}

[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/chrome/browser/about_flags.cc
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/chrome/browser/resources/options/password_manager.html
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/chrome/browser/resources/options/password_manager.js
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/chrome/browser/ui/webui/options/password_manager_handler.cc
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/content/child/runtime_features.cc
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/content/public/android/java/src/org/chromium/content/common/ContentSwitches.java
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/content/public/common/content_features.cc
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/content/public/common/content_features.h
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/third_party/WebKit/LayoutTests/external/wpt/credential-management/idl.https.html
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-frame-errors.html
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/third_party/WebKit/Source/modules/credentialmanager/Credential.idl
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/third_party/WebKit/Source/modules/credentialmanager/CredentialUserData.idl
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.idl
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.idl
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.idl
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/44ca0605b598508b94a2cf0ccb4d37b8023ef3fb/tools/metrics/histograms/histograms.xml