New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715075 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 16 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Payments] Desktop: Editing a credit card does not update the description in Payment Sheet

Project Member Reported by ma...@chromium.org, Apr 25 2017

Issue description

Steps:
(1) have a card with a missing name
(2) name is not there in the payment sheet (i.e. only Visa **** 1111 is shown)
(3) Edit the card in the editor to add a name
(4) Go back to the payment sheet

Expected:
Name is there

Current:
Name is not there

If you reload the payment request, name is there.
 

Comment 1 by ma...@chromium.org, Apr 27 2017

Cc: ma...@chromium.org
Owner: mad@chromium.org
Hi MAD, since you are looking at this code perhaps you will find a fix for this.

Comment 2 by mad@chromium.org, May 23 2017

Status: Started (was: Available)

Comment 3 by mad@chromium.org, May 29 2017

Status: Fixed (was: Started)
https://codereview.chromium.org/2912453002/

Comment 4 by ma...@chromium.org, May 29 2017

Labels: Merge-Request-60
Project Member

Comment 5 by sheriffbot@chromium.org, May 30 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks for the fix. 

Please confirm whether the fix is verified in canary. If yes, merge to 3112 branch before 4.00 PM PST(05/31) to make it to next release.
Project Member

Comment 7 by bugdroid1@chromium.org, May 31 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d47d4d22065a0867902ae19fd07e9271068e2a9

commit 8d47d4d22065a0867902ae19fd07e9271068e2a9
Author: Mathieu Perreault <mathp@chromium.org>
Date: Wed May 31 17:56:53 2017

Make payment instrument labels dynamic

BUG= 715075 

Review-Url: https://codereview.chromium.org/2912453002
Cr-Original-Commit-Position: refs/heads/master@{#475063}
Review-Url: https://codereview.chromium.org/2913223002 .
Cr-Commit-Position: refs/branch-heads/3112@{#60}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/8d47d4d22065a0867902ae19fd07e9271068e2a9/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
[modify] https://crrev.com/8d47d4d22065a0867902ae19fd07e9271068e2a9/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/8d47d4d22065a0867902ae19fd07e9271068e2a9/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/8d47d4d22065a0867902ae19fd07e9271068e2a9/components/payments/core/autofill_payment_instrument.cc
[modify] https://crrev.com/8d47d4d22065a0867902ae19fd07e9271068e2a9/components/payments/core/autofill_payment_instrument.h
[modify] https://crrev.com/8d47d4d22065a0867902ae19fd07e9271068e2a9/components/payments/core/payment_instrument.cc
[modify] https://crrev.com/8d47d4d22065a0867902ae19fd07e9271068e2a9/components/payments/core/payment_instrument.h

Labels: Needs-Feedback
Tested the issue on Mac 10.12.4 , Windows 7 using chrome#60.0.3112.10  as per the steps mentioned in comment#0.
Unable to save the card without name.
Please find the attached screencast for reference & let us know if we miss any steps / URL's to proceed further.

Thanks in advance.

715075.mp4
1.4 MB View Download
Cc: jmukthavaram@chromium.org

Comment 10 by mad@chromium.org, Jun 1 2017

You don't need to save card without a name to reproduce, you could save it
with a name and then change the name.

But if you would want to try creating a card without a name, you could do
it from the autofill settings as opposed to payment request you.

Le 1 juin 2017 05 h 47, "jmukthavaram via monorail" <
monorail+v2.3447642152@chromium.org> a écrit :
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment