[Payments] Desktop: Editing a credit card does not update the description in Payment Sheet |
||||||||
Issue descriptionSteps: (1) have a card with a missing name (2) name is not there in the payment sheet (i.e. only Visa **** 1111 is shown) (3) Edit the card in the editor to add a name (4) Go back to the payment sheet Expected: Name is there Current: Name is not there If you reload the payment request, name is there.
,
May 23 2017
,
May 29 2017
,
May 29 2017
,
May 30 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 30 2017
Thanks for the fix. Please confirm whether the fix is verified in canary. If yes, merge to 3112 branch before 4.00 PM PST(05/31) to make it to next release.
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d47d4d22065a0867902ae19fd07e9271068e2a9 commit 8d47d4d22065a0867902ae19fd07e9271068e2a9 Author: Mathieu Perreault <mathp@chromium.org> Date: Wed May 31 17:56:53 2017 Make payment instrument labels dynamic BUG= 715075 Review-Url: https://codereview.chromium.org/2912453002 Cr-Original-Commit-Position: refs/heads/master@{#475063} Review-Url: https://codereview.chromium.org/2913223002 . Cr-Commit-Position: refs/branch-heads/3112@{#60} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/8d47d4d22065a0867902ae19fd07e9271068e2a9/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc [modify] https://crrev.com/8d47d4d22065a0867902ae19fd07e9271068e2a9/chrome/browser/ui/views/payments/payment_method_view_controller.cc [modify] https://crrev.com/8d47d4d22065a0867902ae19fd07e9271068e2a9/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc [modify] https://crrev.com/8d47d4d22065a0867902ae19fd07e9271068e2a9/components/payments/core/autofill_payment_instrument.cc [modify] https://crrev.com/8d47d4d22065a0867902ae19fd07e9271068e2a9/components/payments/core/autofill_payment_instrument.h [modify] https://crrev.com/8d47d4d22065a0867902ae19fd07e9271068e2a9/components/payments/core/payment_instrument.cc [modify] https://crrev.com/8d47d4d22065a0867902ae19fd07e9271068e2a9/components/payments/core/payment_instrument.h
,
Jun 1 2017
Tested the issue on Mac 10.12.4 , Windows 7 using chrome#60.0.3112.10 as per the steps mentioned in comment#0. Unable to save the card without name. Please find the attached screencast for reference & let us know if we miss any steps / URL's to proceed further. Thanks in advance.
,
Jun 1 2017
,
Jun 1 2017
You don't need to save card without a name to reproduce, you could save it with a name and then change the name. But if you would want to try creating a card without a name, you could do it from the autofill settings as opposed to payment request you. Le 1 juin 2017 05 h 47, "jmukthavaram via monorail" < monorail+v2.3447642152@chromium.org> a écrit :
,
Jun 27 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ma...@chromium.org
, Apr 27 2017Owner: mad@chromium.org