gn android_assets() doesn't recognize file modification
Reported by
elad.alon@webrtc.org,
Apr 25 2017
|
|||
Issue descriptionSteps to reproduce the problem: 1. Create an APK target using android_assets(), with at least one file (I used a .wav file) under renaming_sources-renaming_destinations. 2. Build APK. 3. Modify one of the assets. Change the file itself, without touching the BUILD.gn file at all. 4. Build the APK again. 5. The build procedure does not recognize that the file was modified, and does not re-pack the (modified) asset. What is the expected behavior? APK built with modified asset inside it. What went wrong? See above. :-) Did this work before? N/A Chrome version: 57.0.2987.133 Channel: stable OS Version: Flash Version: Shockwave Flash 25.0 r0
,
Apr 25 2017
Thanks for reporting! Certainly an issue. Fix on the way.
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5951c34be6da4c8a59563a1f8abc05918d6b0e8c commit 5951c34be6da4c8a59563a1f8abc05918d6b0e8c Author: agrieve <agrieve@chromium.org> Date: Tue Apr 25 15:07:49 2017 Android: Fix incremental builds not noticing when assets change BUG= 715057 Review-Url: https://codereview.chromium.org/2841883002 Cr-Commit-Position: refs/heads/master@{#466992} [modify] https://crrev.com/5951c34be6da4c8a59563a1f8abc05918d6b0e8c/build/android/gyp/apkbuilder.py
,
Apr 25 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by minyue@chromium.org
, Apr 25 2017