New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715054 link

Starred by 1 user
Status: Fixed
Merged: issue 708844
Owner:
█ dfalcant...@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
tedc...@chromium.org
█ dfalcant...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

FirstRunIntegrationTest#testClickThroughFirstRun failing on chromium.android bots

Project Member Reported by perezju@chromium.org, Apr 25 2017 
Appears to be failing on:
- Lollipop Phone Tester
- Lollipop Tablet Tester
- Marshmallow 64 bit Tester
- Marshmallow Tablet Tester

For example:
https://luci-milo.appspot.com/buildbot/chromium.android/Lollipop%20Phone%20Tester/11548

Error log shows:
I  358.257s run_tests_on_device(06deea0b00ecb4da)  detected failure in org.chromium.chrome.browser.firstrun.FirstRunIntegrationTest#testClickThroughFirstRun. raw output:
I  358.257s run_tests_on_device(06deea0b00ecb4da)    INSTRUMENTATION_STATUS: numtests=1
I  358.257s run_tests_on_device(06deea0b00ecb4da)    INSTRUMENTATION_STATUS: stream=
I  358.257s run_tests_on_device(06deea0b00ecb4da)    org.chromium.chrome.browser.firstrun.FirstRunIntegrationTest:
I  358.257s run_tests_on_device(06deea0b00ecb4da)    INSTRUMENTATION_STATUS: id=InstrumentationTestRunner
I  358.257s run_tests_on_device(06deea0b00ecb4da)    INSTRUMENTATION_STATUS: test=testClickThroughFirstRun
I  358.257s run_tests_on_device(06deea0b00ecb4da)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.firstrun.FirstRunIntegrationTest
I  358.257s run_tests_on_device(06deea0b00ecb4da)    INSTRUMENTATION_STATUS: current=1
I  358.257s run_tests_on_device(06deea0b00ecb4da)    INSTRUMENTATION_STATUS_CODE: 1
I  358.257s run_tests_on_device(06deea0b00ecb4da)    INSTRUMENTATION_RESULT: shortMsg=junit.framework.AssertionFailedError
I  358.257s run_tests_on_device(06deea0b00ecb4da)    INSTRUMENTATION_RESULT: longMsg=junit.framework.AssertionFailedError
I  358.257s run_tests_on_device(06deea0b00ecb4da)    INSTRUMENTATION_CODE: 0
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FLollipop_Phone_Tester%2F11541%2F%2B%2Frecipes%2Fsteps%2Fchrome_public_test_apk_on_Android%2F0%2Fstdout

Comment 1 by perezju@chromium.org, Apr 25 2017

Cc: tedc...@chromium.org dfalcant...@chromium.org
So far from the commit range:
http://test-results.appspot.com/revision_range?start=466832&end=466843

The following looks suspicious:
Don't display the search engine until First Run completes
https://codereview.chromium.org/2834253002

Comment 2 by perezju@chromium.org, Apr 25 2017 

Confirmed this CL appears on the first failure of all 4 bots. Will proceed with a speculative revert.

Comment 3 by dfalcant...@chromium.org, Apr 25 2017

Mergedinto: 708844
Owner: dfalcant...@chromium.org
Status: Duplicate (was: Untriaged)
Will track this on the main bug. Thanks!

Comment 4 by dfalcant...@chromium.org, Apr 25 2017 

FWIW, I can't repro this failure locally on two devices :/

Comment 5 by dfalcant...@chromium.org, Apr 25 2017

Status: Started (was: Duplicate)
Eh, I'm already commenting here anyway.  Unmarking as a dupe.

This is a timing issue.  The button that needs to be clicked takes a while to show up on some devices.

Comment 6 by dfalcant...@chromium.org, Apr 25 2017 

Hrm, not a timing issue.  It's a flow issue where having no google accounts on the device skips the sign-in screen.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9dd458eef1094639d4216edcf95a01d1f248f1d

commit c9dd458eef1094639d4216edcf95a01d1f248f1d
Author: dfalcantara <dfalcantara@chromium.org>
Date: Tue Apr 25 21:41:10 2017

🔍 Reland: Don't display the search engine until First Run completes

* Adds a check to prevent showing branding if First Run hasn't completed.

* Updates the widget so that it is updated when an AsyncInitializationActivity
  subclass calls onDeferredStartup().

* Changes the resource for the microphone to match the omnibox's, as well as
  uses its content description.

* Adds tests to confirm that the search engine is updated once First Run
  completes.

BUG= 708844 ,710952, 715054 

Original-Review-Url: https://codereview.chromium.org/2834253002
Original-Cr-Commit-Position: refs/heads/master@{#466839}
Review-Url: https://codereview.chromium.org/2837343002
Cr-Commit-Position: refs/heads/master@{#467122}

[modify] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/java/res/layout/search_widget_template.xml
[modify] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
[modify] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
[modify] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/java_sources.gni
[add] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunActivityTestObserver.java
[modify] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
[modify] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProviderTest.java
[modify] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java

Comment 8 by dfalcant...@chromium.org, Apr 25 2017

Status: Fixed (was: Started)
Hopefully fixed.
►

Sign in to add a comment