[MD-Incognito NTP] Unnecessary Incognito NTP flickering is observed on reloading page
Reported by
abom...@etouch.net,
Apr 25 2017
|
||||||||
Issue descriptionChrome Version:60.0.3080.0 (Official Build) Revision 70d2a00a72c50c344436f139b2a3f5c09ec337bf-refs/heads/master@{#466837} OS:Windows(7,8,10), Mac(10.11.6, 10.12.1, 10.12) and Linux(14.04 LTS) Pre-condition: Enable Material Design Incognito NTP flag. What steps will reproduce the problem? 1. Launch chrome and open Incognito window from wrench ( or press Ctrl+Shift+N) 2. Reload Incognito NTP page and observe. Actual: Unnecessary Incognito NTP flickering is observed. Expected: Flickering should not be seen on reloading the page This is non-regression issue, as above flags is introduced in ‘M -60’ (60.0.3080.0)
,
Apr 28 2017
There's one JS calculation used in the layout, which is probably causing this. I'll see what I can do.
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24526e022f84a2a625012160b818eef0ebd0b8de commit 24526e022f84a2a625012160b818eef0ebd0b8de Author: msramek <msramek@chromium.org> Date: Fri May 19 13:27:38 2017 Speed up the Incognito NTP reload As described in crbug.com/715042 , the new Incognito NTP sometimes flickers on reload. This is likely caused by the fact that it uses JavaScript when computing layout, including two relatively heavy offsetWidth operations which cause a reflow. However, offsetWidth is constant for a given default font size, and only needs to be computed once. It can be then stored in localStorage for the duration of the Incognito session. Testing on my local debug build shows that the JavaScript execution is now sped up from ~22ms to ~5ms. BUG= 715042 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2888103002 Cr-Commit-Position: refs/heads/master@{#473176} [modify] https://crrev.com/24526e022f84a2a625012160b818eef0ebd0b8de/chrome/browser/resources/ntp4/md_incognito_tab.js
,
May 19 2017
The CL in #3 sped up the page reload more than 4X on my testing machine, which hopefully solves the flickering. Please reopen if that isn't the case.
,
May 23 2017
Tested the issue on Chrome Dev# 60.0.3107.4 on Windows, Mac and Linux. The issue is still reproducible on Windows and Linux. Re-assigning to the concern owner. @msramek -- Could you please look into issue and provide an update. Note: The issue is found to be fixed on Macbook OS X 10.12.4 Sierra. Thank You. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ranjitkan@chromium.org
, Apr 25 2017