New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715039 link

Starred by 1 user
Status: Fixed
Owner:
mastiz@chromium.org
Closed: Apr 2017
Cc:
█ atanasova@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Allow PopularSites to specify HTTP path subdir via Variations

Project Member Reported by mastiz@chromium.org, Apr 25 2017 
The existing Chrome variations parameters allow overriding the version and the country, used to fetch the JSON containing Popular Sites from Google Servers.

In order to separate different channels more cleanly, specifying a subpath would be interesting. Until now, the version is used for this purpose, but this presents some limitations.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7df710ad0b5371c434f70df7d10c742b2bd6e043

commit 7df710ad0b5371c434f70df7d10c742b2bd6e043
Author: mastiz <mastiz@chromium.org>
Date: Wed Apr 26 11:09:10 2017

[Popular Sites] Add Variations parameter to override URL path

This new parameter intends to replace or complement the version override
param to distinguish various published versions of Popular Sites.

BUG= 715039 

Review-Url: https://codereview.chromium.org/2841643005
Cr-Commit-Position: refs/heads/master@{#467294}

[modify] https://crrev.com/7df710ad0b5371c434f70df7d10c742b2bd6e043/components/ntp_tiles/popular_sites.h
[modify] https://crrev.com/7df710ad0b5371c434f70df7d10c742b2bd6e043/components/ntp_tiles/popular_sites_impl.cc
[modify] https://crrev.com/7df710ad0b5371c434f70df7d10c742b2bd6e043/components/ntp_tiles/popular_sites_impl.h
[modify] https://crrev.com/7df710ad0b5371c434f70df7d10c742b2bd6e043/components/ntp_tiles/popular_sites_impl_unittest.cc
[modify] https://crrev.com/7df710ad0b5371c434f70df7d10c742b2bd6e043/components/ntp_tiles/pref_names.cc
[modify] https://crrev.com/7df710ad0b5371c434f70df7d10c742b2bd6e043/components/ntp_tiles/pref_names.h
[modify] https://crrev.com/7df710ad0b5371c434f70df7d10c742b2bd6e043/components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc
[modify] https://crrev.com/7df710ad0b5371c434f70df7d10c742b2bd6e043/components/ntp_tiles/webui/popular_sites_internals_message_handler.cc
[modify] https://crrev.com/7df710ad0b5371c434f70df7d10c742b2bd6e043/components/ntp_tiles/webui/resources/ntp_tiles_internals.html
[modify] https://crrev.com/7df710ad0b5371c434f70df7d10c742b2bd6e043/components/ntp_tiles/webui/resources/ntp_tiles_internals.js
[modify] https://crrev.com/7df710ad0b5371c434f70df7d10c742b2bd6e043/components/ntp_tiles/webui/resources/popular_sites_internals.html
[modify] https://crrev.com/7df710ad0b5371c434f70df7d10c742b2bd6e043/components/ntp_tiles/webui/resources/popular_sites_internals.js

Comment 2 by mastiz@chromium.org, Apr 26 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment