New issue
Advanced search Search tips

Issue 715034 link

Starred by 1 user
Status: Fixed
Owner:
hayato@chromium.org
Closed: May 2017
Cc:
alemate@chromium.org
dbeam@chromium.org
dpa...@chromium.org
achuith@chromium.org
hayato@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 715407
issue 715414
issue 715440
issue 715441
Blocking:
issue 489954



Sign in to add a comment

Remove/rewrite all tests which use either /deep/ or ::shadow (in CSS dynamic profile)

Project Member Reported by hayato@chromium.org, Apr 25 2017 
I am working on disabling /deep/ (and removing ::shadow) for M60.
See https://codereview.chromium.org/2778983006

However, it turned out that there are not-a-few tests which still use /deep/ (or ::shadow). I am afraid that the CL would be bigger and bigger, and it would be difficult to land the CL as one giant CL.

Instead of landing all changes together, it would be better to remove or rewrite tests incrementally, as separated CLs from the main CL.

After that, we can land the main CL, which actually disable /deep/ (and remove ::shadow), hopefully.

If it would take some time to rewrite some tests, I am afraid that we have to disable some of tests so that we can fix or rewrite tests later.

Comment 1 by hayato@chromium.org, Apr 26 2017

Summary: Remove/rewrite all tests which use either /deep/ or ::shadow (in CSS dynamic profile) (was: Remove/rewrites all tests which use either /deep/ or ::shadow (in CSS dynamic profile))

Comment 2 by hayato@chromium.org, Apr 26 2017

Blockedon: 715407

Comment 3 by hayato@chromium.org, Apr 26 2017

Blockedon: 715414

Comment 4 by hayato@chromium.org, Apr 26 2017

Blockedon: 715440

Comment 5 by hayato@chromium.org, Apr 26 2017

Blockedon: 715441
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9

commit dc1b7c2d8519a2a441edc32a72bb5d8298b134c9
Author: hayato <hayato@chromium.org>
Date: Wed Apr 26 08:37:03 2017

Remove, or rewrite if necessary, tests which use /deep/ or ::shadow

This is a preparation CL for https://codereview.chromium.org/2778983006.

There are still other tests which will fail when /deep/ (or ::shadow) is disabled.
These tests are being tracked in meta  bug 715034 .

BUG= 715034 

Review-Url: https://codereview.chromium.org/2843883002
Cr-Commit-Position: refs/heads/master@{#467269}

[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/css/deep-cascade-order-expected.txt
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/css/deep-cascade-order.html
[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/LayoutTests/fast/css/invalidation/detach-reattach-shadow-expected.txt
[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/LayoutTests/fast/css/invalidation/detach-reattach-shadow.html
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-boundary-crossing-expected.txt
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-boundary-crossing.html
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/css/invalidation/targeted-class-shadow-combinator-expected.txt
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/css/invalidation/targeted-class-shadow-combinator.html
[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules-expected.txt
[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules.html
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/content-deep-expected.txt
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/content-deep.html
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-deep-combinator-and-host-pseudo-class-expected.txt
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-deep-combinator-and-host-pseudo-class.html
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-shadow-pseudo-element-and-host-pseudo-class-expected.txt
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-shadow-pseudo-element-and-host-pseudo-class.html
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/dynamically-added-deep-combinator-and-shadow-pseudo-element-expected.txt
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/dynamically-added-deep-combinator-and-shadow-pseudo-element.html
[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/LayoutTests/fast/dom/shadow/scrollbar.html
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-and-list-elements-expected.html
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-and-list-elements.html
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-pseudo-element-expected.txt
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-pseudo-element.html
[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-reprojection-1-expected.html
[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-reprojection-1.html
[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-reprojection-2-expected.html
[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-reprojection-2.html
[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/LayoutTests/fast/dom/shadow/style-and-shadow-element-expected.txt
[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/LayoutTests/fast/dom/shadow/style-and-shadow-element.html
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/style-with-deep-combinator-expected.txt
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/style-with-deep-combinator.html
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element-expected.txt
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element.html
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/stylesheets-order-in-shadow-dom-expected.txt
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/fast/dom/shadow/stylesheets-order-in-shadow-dom.html
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/shadow-dom/v0/cascade-deep-in-v1-expected.txt
[delete] https://crrev.com/ec1e14279dd9294f4640ea7fd67ea40532a572b0/third_party/WebKit/LayoutTests/shadow-dom/v0/cascade-deep-in-v1.html
[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/LayoutTests/svg/dom/custom-elements.html
[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp
[modify] https://crrev.com/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9/third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp

Comment 7 by dpa...@chromium.org, May 2 2017

Cc: dbeam@chromium.org
@hayato: FYI, removing /deep/ will regress ChromeOS Login UI see [1]. All those usages of iron-flex-layout.html need to be migrated to iron-flex-layout-classes.html similar to what I did for MD Settigs at  issue 635633 .

[1] https://cs.chromium.org/search/?q=iron-flex-layout+file:%5Esrc/chrome/browser/resources/chromeos/+package:%5Echromium$&type=cs

Comment 8 by dpa...@chromium.org, May 2 2017

Cc: dpa...@chromium.org

Comment 9 Deleted

Comment 10 by dpa...@chromium.org, May 2 2017

Cc: alemate@chromium.org achuith@chromium.org
+achuith, alemate who are OWNERS of OOBE WebUI. See comment #7.

Comment 11 by hayato@chromium.org, May 8 2017 

@dpapad,

Thank you! Let me file a separate issue for Chrome OS Login UI, cc-ing relevant people. I hope that would be the last blocking issue.
https://bugs.chromium.org/p/chromium/issues/detail?id=719331

Comment 12 by hayato@chromium.org, May 8 2017

Status: Fixed (was: Assigned)
Now it looks all test pass, as per the try result. Let me close this issue.
I hope the remaining blocking issue for  bug 489954  is only the  bug 719331 .
►

Sign in to add a comment