Investigate making ShellLinkItem not refcounted |
||
Issue descriptionIt's not obvious that there's a need for ShellLinkItem to be refcounted. If possible, massage things so that item ownership is clear and that instances are held in std::unique_ptrs rather than scoped_refptrs.
,
Nov 26
The ShellLinkItem object is now stored in two different container objects. See the following code snippet for an example: https://cs.chromium.org/chromium/src/chrome/browser/win/jumplist.cc?l=458-460 In this example, |link| is stored in both |most_visited_pages_| and |icon_urls_|. In this case, I think shared pointer is more appropriate.
,
Nov 28
|
||
►
Sign in to add a comment |
||
Comment 1 by chengx@chromium.org
, Apr 25 2017