Fix new warnings in libweave |
|||||
Issue description
libweave has new warnings when testing with newer version of llvm which we want to use. This block the toolchain update to llvm.
libweave-0.0.1-r240: i686-pc-linux-gnu-g++ -MMD -MF weave/libweave/src/privet/libweave_common.privet_handler.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/build/x86-generic/tmp/portage/chromeos-base/libweave-0.0.1-r240/work/libweave-0.0.1/weave/libweave -I/build/x86-generic/tmp/portage/chromeos-base/libweave-0.0.1-r240/work/libweave-0.0.1/weave/libweave/include -I/build/x86-generic/tmp/portage/chromeos-base/libweave-0.0.1-r240/work/libweave-0.0.1/weave/libweave/third_party/modp_b64/modp_b64 -I/build/x86-generic/tmp/portage/chromeos-base/libweave-0.0.1-r240/work/libweave-0.0.1/weave/libweave/third_party/libuweave -Iweave/libweave/libweave_common.gen/include -Igen/include -I/build/x86-generic/tmp/portage/chromeos-base/libweave-0.0.1-r240/work/libweave-0.0.1/platform2 -I/build/x86-generic/tmp/portage/chromeos-base/libweave-0.0.1-r240/work/libweave-0.0.1/platform -I/build/x86-generic/usr/include -Wall -Wno-psabi -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Werror --sysroot=/build/x86-generic -fPIC -Wno-c++11-extensions -Wno-unused-local-typedefs -DBASE_VER=395517 -pthread -I/build/x86-generic/usr/include/base-395517 -I/build/x86-generic/usr/include/glib-2.0 -I/build/x86-generic/usr/lib/glib-2.0/include -I/build/x86-generic/usr/include/nss -I/build/x86-generic/usr/include/nspr -I/build/x86-generic/usr/include/dbus-1.0 -I/build/x86-generic/usr/lib/dbus-1.0/include -std=gnu++11 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -march=i686 -pipe -O2 -march=i686 -pipe -O2 -pipe -march=i686 -mfpmath=sse -mmmx -msse -msse2 -msse3 -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -clang-syntax -clang-syntax -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -c ../../../../../../../tmp/portage/chromeos-base/libweave-0.0.1-r240/work/libweave-0.0.1/weave/libweave/src/privet/privet_handler.cc -o weave/libweave/src/privet/libweave_common.privet_handler.o
libweave-0.0.1-r240: ../../../../../../../tmp/portage/chromeos-base/libweave-0.0.1-r240/work/libweave-0.0.1/weave/libweave/src/privet/privet_handler.cc:384:16: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
libweave-0.0.1-r240: auto pred = [this](const UpdateRequestParameters& params) {
libweave-0.0.1-r240: ^
libweave-0.0.1-r240: ../../../../../../../tmp/portage/chromeos-base/libweave-0.0.1-r240/work/libweave-0.0.1/weave/libweave/src/privet/privet_handler.cc:396:16: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
libweave-0.0.1-r240: auto pred = [this](const UpdateRequestParameters& params) {
libweave-0.0.1-r240: ^
libweave-0.0.1-r240: 2 errors generated.
The error can be fixed by removing this from lambda capture.
,
Apr 26 2017
Change submitted and https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/chromiumos-sdk/builds/2202 build passed.
,
Apr 28 2017
There is another warning here: https://build.chromium.org/p/chromiumos/builders/amd64-generic-paladin/builds/29203/steps/UnitTest/logs/stdio libweave-0.0.1-r249: [43/94] CXX weave/libweave/src/libweave_testrunner.device_registration_info_unittest.o libweave-0.0.1-r249: FAILED: weave/libweave/src/libweave_testrunner.device_registration_info_unittest.o libweave-0.0.1-r249: x86_64-cros-linux-gnu-clang++ -MMD -MF weave/libweave/src/libweave_testrunner.device_registration_info_unittest.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/build/amd64-generic/tmp/portage/chromeos-base/libweave-0.0.1-r249/work/libweave-0.0.1/weave/libweave -I/build/amd64-generic/tmp/portage/chromeos-base/libweave-0.0.1-r249/work/libweave-0.0.1/weave/libweave/include -I/build/amd64-generic/tmp/portage/chromeos-base/libweave-0.0.1-r249/work/libweave-0.0.1/weave/libweave/third_party/modp_b64/modp_b64 -I/build/amd64-generic/tmp/portage/chromeos-base/libweave-0.0.1-r249/work/libweave-0.0.1/weave/libweave/third_party/libuweave -Iweave/libweave/libweave_testrunner.gen/include -Igen/include -I/build/amd64-generic/tmp/portage/chromeos-base/libweave-0.0.1-r249/work/libweave-0.0.1/platform2 -I/build/amd64-generic/tmp/portage/chromeos-base/libweave-0.0.1-r249/work/libweave-0.0.1/platform -I/build/amd64-generic/usr/include -Wall -Wno-psabi -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Werror --sysroot=/build/amd64-generic -Wno-c++11-extensions -Wno-unused-local-typedefs -DBASE_VER=395517 -pthread -I/build/amd64-generic/usr/include/base-395517 -I/build/amd64-generic/usr/include/glib-2.0 -I/build/amd64-generic/usr/lib64/glib-2.0/include -I/build/amd64-generic/usr/include/nss -I/build/amd64-generic/usr/include/nspr -I/build/amd64-generic/usr/include/dbus-1.0 -I/build/amd64-generic/usr/lib64/dbus-1.0/include -fPIE -std=gnu++11 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -pipe -O2 -pipe -O2 -pipe -march=x86-64 -msse3 -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -clang-syntax -clang-syntax -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -c ../../../../../../../tmp/portage/chromeos-base/libweave-0.0.1-r249/work/libweave-0.0.1/weave/libweave/src/device_registration_info_unittest.cc -o weave/libweave/src/libweave_testrunner.device_registration_info_unittest.o libweave-0.0.1-r249: ../../../../../../../tmp/portage/chromeos-base/libweave-0.0.1-r249/work/libweave-0.0.1/weave/libweave/src/device_registration_info_unittest.cc:342:32: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture] libweave-0.0.1-r249: auto callback = [&succeeded, this](const base::DictionaryValue& info, libweave-0.0.1-r249: ^ libweave-0.0.1-r249: 1 error generated. I'll send another CL with a similar fix.
,
Apr 28 2017
Proposed fix: https://weave-review.googlesource.com/#/c/9950/
,
Apr 28 2017
,
May 2 2017
No warnings now. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by manojgupta@chromium.org
, Apr 25 2017