New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714970 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

linux_chromium_rel_ng doesn't execute webkit_tests step for some blink CLs

Project Member Reported by wangxianzhu@chromium.org, Apr 25 2017

Issue description

For example, https://codereview.chromium.org/2836143003/#ps20001 is expected to fail all webkit_tests steps, but linux_chromium_rel_ng is green.

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/437989 shows that no webkit_tests step was executed.

The CL changes code under third_party/WebKit/Source/core/style.
 
Components: -Infra>CQ Infra>Client>Chrome
Status: Untriaged (was: Available)
Cc: tansell@chromium.org
Build link: https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/437989

Analyze step link: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_rel_ng%2F437989%2F%2B%2Frecipes%2Fsteps%2Fanalyze%2F0%2Fstdout

Tim, do you know if this is currently relevant after the latest changes for  bug 703894  (switching BlinkTests to analyze-based running)?
It looks like the analyze step didn't think webkit_layout_tests target should be run -> https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_rel_ng%2F437989%2F%2B%2Frecipes%2Fsteps%2Fanalyze%2F0%2Fstdout

Trying to figure out why...
When run locally, it seems to work...

- analyze.json -----
{
  "additional_compile_targets": [
    "//:chromium_swarm_tests", 
    "all"
  ], 
  "files": [
    "//third_party/WebKit/LayoutTests/paint/invalidation/border-current-color-expected.html", 
    "//third_party/WebKit/LayoutTests/paint/invalidation/border-current-color-expected.txt", 
    "//third_party/WebKit/LayoutTests/paint/invalidation/border-current-color.html", 
    "//third_party/WebKit/LayoutTests/paint/invalidation/outline-current-color-expected.html", 
    "//third_party/WebKit/LayoutTests/paint/invalidation/outline-current-color-expected.txt", 
    "//third_party/WebKit/LayoutTests/paint/invalidation/outline-current-color.html", 
    "//third_party/WebKit/Source/core/layout/LayoutObject.cpp", 
    "//third_party/WebKit/Source/core/style/BorderData.h", 
    "//third_party/WebKit/Source/core/style/ComputedStyle.h", 
    "//third_party/WebKit/Source/core/style/ComputedStyleTest.cpp"
  ], 
  "test_targets": [
    "//:webkit_layout_tests_exparchive", 
    "//content/shell:content_shell_crash_test", 
    "//content/test:content_browsertests", 
    "//content/test:content_unittests"
  ]
}
---------

buildtools/linux64/gn analyze //out/Release analyze.json analyze-out.json

- analyze-out.json --------
{
  "compile_targets": [
    "//cc/blink:cc_blink_unittests", 
    "//chrome/test:browser_tests", 
    "//chrome/test:chrome_app_unittests", 
    "//chrome/test:interactive_ui_tests", 
    "//chrome/test:performance_browser_tests", 
    "//chrome/test:sync_integration_tests", 
    "//chrome/test:sync_performance_tests", 
    "//chrome/test:unit_tests", 
    "//chrome/tools/service_discovery_sniffer:service_discovery_sniffer", 
    "//chrome:chrome_initial", 
    "//components/metrics:metrics_unittests", 
    "//components/nacl/loader:nacl_helper", 
    "//components/nacl/loader:nacl_loader_unittests", 
    "//components/offline_pages/content/background_loader:test_support", 
    "//components/password_manager/content/renderer:browser_tests", 
    "//components/rappor:rappor_unittests", 
    "//components/safe_browsing_db:v4_database_unittest", 
    "//components/safe_browsing_db:v4_get_hash_protocol_manager_unittest", 
    "//components/safe_browsing_db:v4_local_database_manager_unittest", 
    "//components/webcrypto:webcrypto_ec_import_key_pkcs8_fuzzer", 
    "//components/webcrypto:webcrypto_ec_import_key_raw_fuzzer", 
    "//components/webcrypto:webcrypto_ec_import_key_spki_fuzzer", 
    "//components/webcrypto:webcrypto_rsa_import_key_pkcs8_fuzzer", 
    "//components/webcrypto:webcrypto_rsa_import_key_spki_fuzzer", 
    "//components:components_browsertests", 
    "//components:components_perftests", 
    "//components:components_unittests", 
    "//content/public/app:both", 
    "//content/shell:content_shell", 
    "//content/test/fuzzer:clear_site_data_fuzzer", 
    "//content/test/fuzzer:origin_trial_token_fuzzer", 
    "//content/test/fuzzer:renderer_fuzzer", 
    "//content/test/fuzzer:renderer_proto_tree_fuzzer", 
    "//content/test/fuzzer:renderer_tree_fuzzer", 
    "//content/test:content_browsertests", 
    "//content/test:content_perftests", 
    "//content/test:content_unittests", 
    "//extensions/shell:app_shell", 
    "//extensions/shell:app_shell_unittests", 
    "//extensions:extensions_browsertests", 
    "//extensions:extensions_unittests", 
    "//headless:headless_browsertests", 
    "//headless:headless_example", 
    "//headless:headless_lib", 
    "//headless:headless_shell", 
    "//headless:headless_unittests", 
    "//media/blink:media_blink_unittests", 
    "//services/navigation:navigation_unittests", 
    "//services:service_unittests", 
    "//third_party/WebKit/Source/bindings/core/v8:v8_serialized_script_value_fuzzer", 
    "//third_party/WebKit/Source/core:content_security_policy_fuzzer", 
    "//third_party/WebKit/Source/core:core", 
    "//third_party/WebKit/Source/core:html_preload_scanner_fuzzer", 
    "//third_party/WebKit/Source/core:stylesheet_contents_fuzzer", 
    "//third_party/WebKit/Source/core:text_resource_decoder_fuzzer", 
    "//third_party/WebKit/Source/modules:modules", 
    "//third_party/WebKit/Source/platform/heap:blink_heap_unittests", 
    "//third_party/WebKit/Source/platform:blink_json_parser_fuzzer", 
    "//third_party/WebKit/Source/platform:blink_platform_unittests", 
    "//third_party/WebKit/Source/platform:blink_png_decoder_fuzzer", 
    "//third_party/WebKit/Source/platform:blink_text_codec_UTF_8_fuzzer", 
    "//third_party/WebKit/Source/platform:blink_text_codec_WINDOWS_1252_fuzzer", 
    "//third_party/WebKit/Source/platform:feature_policy_fuzzer", 
    "//third_party/WebKit/Source/platform:mhtml_parser_fuzzer", 
    "//third_party/WebKit/Source/platform:web_icon_sizes_fuzzer", 
    "//third_party/WebKit/Source/web:web", 
    "//third_party/WebKit/Source/web:webkit_unit_tests", 
    "//tools/ipc_fuzzer/fuzzer:ipc_fuzzer", 
    "//tools/ipc_fuzzer/message_dump:ipc_message_dump", 
    "//tools/ipc_fuzzer/message_replay:ipc_fuzzer_replay", 
    "//tools/ipc_fuzzer/message_tools:ipc_message_list", 
    "//tools/ipc_fuzzer/message_tools:ipc_message_util", 
    "//ui/views/examples:views_examples_with_content_exe"
  ], 
  "status": "Found dependency", 
  "test_targets": [
    "//:webkit_layout_tests_exparchive", 
    "//content/shell:content_shell_crash_test", 
    "//content/test:content_browsertests", 
    "//content/test:content_unittests"
  ]
}
---------

Comment 5 Deleted

Comment 6 Deleted

Cc: wangxianzhu@chromium.org qyears...@chromium.org
qyearsley@ / wangzianzhu@ - Can you confirm if this is still happening? Are you able to provide more examples of where this occurred?
I am not sure because it just makes the bot green. Can we query the recent build results to see if this is still happening and find the examples?
Status: Fixed (was: Untriaged)
I believe this is fixed.

Sign in to add a comment