New issue
Advanced search Search tips

Issue 714956 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 586413



Sign in to add a comment

Defer enabling line-height-step on stable

Project Member Reported by kojii@chromium.org, Apr 25 2017

Issue description

While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c9c589259849ee69875a9d173a98f5fb2c0fde6

commit 0c9c589259849ee69875a9d173a98f5fb2c0fde6
Author: kojii <kojii@chromium.org>
Date: Tue Apr 25 07:11:08 2017

Postpone enabling CSS line-height-step on stable

This patch postpones r462778[1] that enabled CSS line-height-step on
stable.

While we do not see web-compat risks, we heard that enabling on stable
gives a pressure to discussions, and that delaying can make it easier.

We expect this feature to grow only slowly. The previous similar feature
was at 0.007% UMA. I hope this property will be used more widely by East
Asians, but it will still take time to grow. Delaying by a few months
will not make much differences in the value of the feature.

[1] https://codereview.chromium.org/2797973005

BUG= 714956 

Review-Url: https://codereview.chromium.org/2833323002
Cr-Commit-Position: refs/heads/master@{#466910}

[modify] https://crrev.com/0c9c589259849ee69875a9d173a98f5fb2c0fde6/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/0c9c589259849ee69875a9d173a98f5fb2c0fde6/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Comment 2 by kojii@chromium.org, Apr 25 2017

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 26 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ef31d96fb858f9b220c9292401533cbb301d9c7

commit 1ef31d96fb858f9b220c9292401533cbb301d9c7
Author: Koji Ishii <kojii@chromium.org>
Date: Wed Apr 26 18:52:45 2017

Merge 3071: Postpone enabling CSS line-height-step on stable

This patch postpones r462778[1] that enabled CSS line-height-step on
stable.

While we do not see web-compat risks, we heard that enabling on stable
gives a pressure to discussions, and that delaying can make it easier.

We expect this feature to grow only slowly. The previous similar feature
was at 0.007% UMA. I hope this property will be used more widely by East
Asians, but it will still take time to grow. Delaying by a few months
will not make much differences in the value of the feature.

[1] https://codereview.chromium.org/2797973005

BUG= 714956 ,  586413 

Review-Url: https://codereview.chromium.org/2833323002
Cr-Commit-Position: refs/heads/master@{#466910}
(cherry picked from commit 0c9c589259849ee69875a9d173a98f5fb2c0fde6)

Review-Url: https://codereview.chromium.org/2839903004 .
Cr-Commit-Position: refs/branch-heads/3071@{#233}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/1ef31d96fb858f9b220c9292401533cbb301d9c7/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/1ef31d96fb858f9b220c9292401533cbb301d9c7/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Comment 5 by kojii@chromium.org, Apr 26 2017

Status: Fixed (was: Assigned)

Sign in to add a comment