Misleading output on failure in presubmit script for build/ repo. |
|||||||
Issue descriptionhttps://luci-logdog.appspot.com/v/?s=infra%2Fswarm%2Fchromium-swarm.appspot.com%2F35bb60009f967911%2F%2B%2Fsteps%2Fpresubmit%2F0%2Fstdout """ ** Presubmit ERRORS ** tests/masters_recipes_test.py (16.82s) failed !@@@HONOR_ZERO_RETURN_CODE@@@ !@@@SEED_STEP@setup_build@@@ !@@@STEP_CURSOR@setup_build@@@ !@@@STEP_STARTED@@@ !@@@STEP_LOG_LINE@run_recipe@To repro this locally, run the following line from the root of a 'build' checkout:@@@ !@@@STEP_LOG_LINE@run_recipe@@@@ !@@@STEP_LOG_LINE@run_recipe@./scripts/slave/recipes.py run --properties-file - chromium_trybot <<EOF@@@ !@@@STEP_LOG_LINE@run_recipe@{"dump_builders": "/b/s/w/ir/tmp/tmp6gyUFa.json", "recipe": "chromium_trybot"}@@@ !@@@STEP_LOG_LINE@run_recipe@EOF@@@ !@@@STEP_LOG_LINE@run_recipe@@@@ !@@@STEP_LOG_LINE@run_recipe@To run on Windows, you can put the JSON in a file and redirect the@@@ !@@@STEP_LOG_LINE@run_recipe@contents of the file into run_recipe.py, with the < operator.@@@ !@@@STEP_LOG_END@run_recipe@@@ Running recipe with {'dump_builders': '/b/s/w/ir/tmp/tmp6gyUFa.json', 'recipe': 'chromium_trybot'} !@@@STEP_TEXT@running recipe: "chromium_trybot"@@@ !@@@STEP_CLOSED@@@ !@@@SEED_STEP@Dump BUILDERS dict@@@ !@@@STEP_CURSOR@Dump BUILDERS dict@@@ !@@@STEP_STARTED@@@ """ This doesn't work without knowing the contents of the tmp6gyUFa.json, which doesn't appear to be emitted anywhere.
,
Apr 25 2017
fwiw, I was running the CQ on the wrong patch. [Meant to run it on https://chromium-review.googlesource.com/c/466608/] That being said, the output is misleading and perhaps should be fixed?
,
Apr 25 2017
yup, probably.
,
Apr 25 2017
,
Jun 22 2017
Moving to recipes component even though I know this isn't strictly what recipes is for.
,
Jun 22 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 26 2018
I agree that that output is misleading, but given that build repo tests bootstrap of the master itself it's a bit hard to make it less misleading. Also, i'd expect that you can re-run presubmit locally on linux workstation with $ git cl presubmit -f
,
Oct 19
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dpranke@chromium.org
, Apr 25 2017