New issue
Advanced search Search tips

Issue 714950 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

uinput.cros_type_keys loses first few keys

Project Member Reported by drinkcat@chromium.org, Apr 25 2017

Issue description

On DUT, type:
sudo python -m uinput.cros_type_keys $'yourpassword\n'

See that only "password" (+/- 1 or 2 letters) is being typed: the first few letters are lost.
 
Cc: posciak@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8b3c51bf6b3faea3ab5ae661f63c31d621ec7fa8

commit 8b3c51bf6b3faea3ab5ae661f63c31d621ec7fa8
Author: Nicolas Boichat <drinkcat@google.com>
Date: Wed May 24 06:59:11 2017

python-uinput: Move cros_[type_]keys.py out of patch

Makes it easier to edit the 2 python scripts manually, no
code change.

BUG= chromium:714950 
TEST=emerge-elm -av python-uinput
     equery-elm files python-uinput shows the 2 python scripts.

Change-Id: I3789d46d070c1445e5c9bb52877bf6350116441b
Reviewed-on: https://chromium-review.googlesource.com/486559
Commit-Ready: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8b3c51bf6b3faea3ab5ae661f63c31d621ec7fa8/dev-python/python-uinput/python-uinput-0.10.2.ebuild
[delete] https://crrev.com/42f2809d05d1d54781517c2cbcb2fdfb20094a45/dev-python/python-uinput/files/0001-ChromeOS-uinput-wrappers.patch
[add] https://crrev.com/8b3c51bf6b3faea3ab5ae661f63c31d621ec7fa8/dev-python/python-uinput/files/cros_keys.py
[rename] https://crrev.com/8b3c51bf6b3faea3ab5ae661f63c31d621ec7fa8/dev-python/python-uinput/python-uinput-0.10.2-r4.ebuild
[add] https://crrev.com/8b3c51bf6b3faea3ab5ae661f63c31d621ec7fa8/dev-python/python-uinput/files/cros_type_keys.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7ac1acc9ecdc2c65409a449464a88a669043ee36

commit 7ac1acc9ecdc2c65409a449464a88a669043ee36
Author: Nicolas Boichat <drinkcat@google.com>
Date: Fri Jun 02 06:49:25 2017

python-uinput: Add delay before starting to type keys

Kernel/Chrome/ARC takes a while to register the new input device, wait
a little while (200ms), before starting to input characters.

Also take this opportunity to properly capitalize DEFAULT_DELAY
constant.

BUG= chromium:714950 ,b:62209867
TEST=emerge-${B} -av python-uinput && \
       cros deploy --root /usr/local ${IP} python-uinput
     sudo python -m uinput.cros_type_keys $'yourpassword\n'
     => no lost keys

Change-Id: I8d5a4e82eed5ee94f4fa031fce5d728932388397
Reviewed-on: https://chromium-review.googlesource.com/486560
Commit-Ready: Daniel Kurtz <djkurtz@chromium.org>
Tested-by: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@google.com>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>

[rename] https://crrev.com/7ac1acc9ecdc2c65409a449464a88a669043ee36/dev-python/python-uinput/python-uinput-0.10.2-r5.ebuild
[modify] https://crrev.com/7ac1acc9ecdc2c65409a449464a88a669043ee36/dev-python/python-uinput/files/cros_keys.py

Status: Fixed (was: Started)

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment