The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/755b1656f38d135013f24ddd8b6ec046874beed2

commit 755b1656f38d135013f24ddd8b6ec046874beed2
Author: alph <alph@chromium.org>
Date: Tue Apr 25 21:18:10 2017

DevTools: fix aggregated donut chart cache population

The check for stats cache availablity was made on the first task in the main thread
tasks list. If the first task happens to be filtered out, it never gets cache built for
it. Later the cache presence check would look for a cache on the first task, never find
it and forces recaching.

BUG= 714934 

Review-Url: https://codereview.chromium.org/2840463003
Cr-Commit-Position: refs/heads/master@{#467114}

[modify] https://crrev.com/755b1656f38d135013f24ddd8b6ec046874beed2/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65df576fce3007b62084239cc8e37a45aea0368f

commit 65df576fce3007b62084239cc8e37a45aea0368f
Author: sashab <sashab@chromium.org>
Date: Wed Apr 26 03:50:59 2017

Revert of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2840463003/ )

Reason for revert:
Suspected cause of failure of virtual/threaded/inspector/tracing/timeline-js/timeline-runtime-stats.html in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/builds/9644

Original issue's description:
> DevTools: fix aggregated donut chart cache population
>
> The check for stats cache availablity was made on the first task in the main thread
> tasks list. If the first task happens to be filtered out, it never gets cache built for
> it. Later the cache presence check would look for a cache on the first task, never find
> it and forces recaching.
>
> BUG= 714934 
>
> Review-Url: https://codereview.chromium.org/2840463003
> Cr-Commit-Position: refs/heads/master@{#467114}
> Committed: https://chromium.googlesource.com/chromium/src/+/755b1656f38d135013f24ddd8b6ec046874beed2

TBR=pfeldman@chromium.org,alph@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 714934 

Review-Url: https://codereview.chromium.org/2839083002
Cr-Commit-Position: refs/heads/master@{#467223}

[modify] https://crrev.com/65df576fce3007b62084239cc8e37a45aea0368f/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e2708b5c1cb31e5d4dde1f105af1c473795d3b9

commit 2e2708b5c1cb31e5d4dde1f105af1c473795d3b9
Author: alph <alph@chromium.org>
Date: Fri Apr 28 20:47:02 2017

Reland of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2839083002/ )

Reason for revert:
The patch has noting to do with the failing test. In fact if you look at the flakiness dashboard the test is very flaky there:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Finspector%2Ftracing%2Ftimeline-js%2Ftimeline-runtime-stats.html

Original issue's description:
> Revert of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2840463003/ )
>
> Reason for revert:
> Suspected cause of failure of virtual/threaded/inspector/tracing/timeline-js/timeline-runtime-stats.html in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/builds/9644
>
> Original issue's description:
> > DevTools: fix aggregated donut chart cache population
> >
> > The check for stats cache availablity was made on the first task in the main thread
> > tasks list. If the first task happens to be filtered out, it never gets cache built for
> > it. Later the cache presence check would look for a cache on the first task, never find
> > it and forces recaching.
> >
> > BUG= 714934 
> >
> > Review-Url: https://codereview.chromium.org/2840463003
> > Cr-Commit-Position: refs/heads/master@{#467114}
> > Committed: https://chromium.googlesource.com/chromium/src/+/755b1656f38d135013f24ddd8b6ec046874beed2
>
> TBR=pfeldman@chromium.org,alph@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 714934 
>
> Review-Url: https://codereview.chromium.org/2839083002
> Cr-Commit-Position: refs/heads/master@{#467223}
> Committed: https://chromium.googlesource.com/chromium/src/+/65df576fce3007b62084239cc8e37a45aea0368f

TBR=pfeldman@chromium.org,sashab@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 714934 

Review-Url: https://codereview.chromium.org/2851823002
Cr-Commit-Position: refs/heads/master@{#468119}

[modify] https://crrev.com/2e2708b5c1cb31e5d4dde1f105af1c473795d3b9/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Can you please mark the OS?

Has this been baked in canary for at least 24 hours, and have you tested and verified the change? This is marked as P2, is it truly critical to get this in for M59 or can it wait until 60?

Yes. Yes, it's critical.

Approving for M59 merge. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e11c90521a0efcfbf05987baa0fb1cbc13e54363

commit e11c90521a0efcfbf05987baa0fb1cbc13e54363
Author: Alexei Filippov <alph@chromium.org>
Date: Mon May 08 20:08:37 2017

Reland of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2839083002/ )

Reason for revert:
The patch has noting to do with the failing test. In fact if you look at the flakiness dashboard the test is very flaky there:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Finspector%2Ftracing%2Ftimeline-js%2Ftimeline-runtime-stats.html

Original issue's description:
> Revert of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2840463003/ )
>
> Reason for revert:
> Suspected cause of failure of virtual/threaded/inspector/tracing/timeline-js/timeline-runtime-stats.html in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/builds/9644
>
> Original issue's description:
> > DevTools: fix aggregated donut chart cache population
> >
> > The check for stats cache availablity was made on the first task in the main thread
> > tasks list. If the first task happens to be filtered out, it never gets cache built for
> > it. Later the cache presence check would look for a cache on the first task, never find
> > it and forces recaching.
> >
> > BUG= 714934 
> >
> > Review-Url: https://codereview.chromium.org/2840463003
> > Cr-Commit-Position: refs/heads/master@{#467114}
> > Committed: https://chromium.googlesource.com/chromium/src/+/755b1656f38d135013f24ddd8b6ec046874beed2
>
> TBR=pfeldman@chromium.org,alph@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 714934 
>
> Review-Url: https://codereview.chromium.org/2839083002
> Cr-Commit-Position: refs/heads/master@{#467223}
> Committed: https://chromium.googlesource.com/chromium/src/+/65df576fce3007b62084239cc8e37a45aea0368f

TBR=pfeldman@chromium.org,sashab@chromium.org
BUG= 714934 

Review-Url: https://codereview.chromium.org/2851823002
Cr-Commit-Position: refs/heads/master@{#468119}
(cherry picked from commit 2e2708b5c1cb31e5d4dde1f105af1c473795d3b9)

Review-Url: https://codereview.chromium.org/2867873002 .
Cr-Commit-Position: refs/branch-heads/3071@{#460}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/e11c90521a0efcfbf05987baa0fb1cbc13e54363/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js