New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 714927 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Apr 2017
Cc:
█ paulkinlan@chromium.org
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Shape detection: https://qrsnapper.appspot.com/ sees "Failed to get pixels for current frame"

Project Member Reported by mcasas@chromium.org, Apr 25 2017
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7d447a09a95eb7ad399eb8512f677a66e127d69

commit d7d447a09a95eb7ad399eb8512f677a66e127d69
Author: mcasas <mcasas@chromium.org>
Date: Wed Apr 26 01:17:13 2017

ShapeDetection: use makeNonTextureImage() to support texture-backed sources

In certain cases (as reported in the bug) the SkImage used for detection
happens to be texture-backed.  This CL uses makeNonTextureImage()
which solves this problem while doing nothing when the SkImage is not
texture backed (i.e. is raster).

BUG= 714927 

Review-Url: https://codereview.chromium.org/2837273003
Cr-Commit-Position: refs/heads/master@{#467192}

[modify] https://crrev.com/d7d447a09a95eb7ad399eb8512f677a66e127d69/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp

Comment 2 by mcasas@chromium.org, Apr 26 2017

Status: Fixed (was: Available)

Comment 3 by mcasas@chromium.org, Apr 27 2017 

Commit d7d447a0... initially landed in 60.0.3082.0

https://qrsnapper.appspot.com works for me but I'm not
sure if it's using the ShapeDetection API in Canary
(it does in Chromium).
►

Sign in to add a comment