New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714926 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 688900



Sign in to add a comment

Add UMA stats for which encryption a user homedir uses

Project Member Reported by dspaid@chromium.org, Apr 25 2017

Issue description

We would like to track how many users are using ext4-crypto versus ecryptfs
 

Comment 1 by uekawa@google.com, Apr 25 2017

Blocking: 688900

Comment 2 by uekawa@google.com, Apr 25 2017

Components: Platform>ARC
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77a4bd9d48145f782e8cc1f3f2f6788001f33060

commit 77a4bd9d48145f782e8cc1f3f2f6788001f33060
Author: dspaid <dspaid@chromium.org>
Date: Fri Apr 28 02:55:47 2017

Add UMA stats for chroemos homedir encryption type

Add a metric to track the type of encryption used by chromeos user
homedirectories.
This histogram is added in chromeos at https://chromium-review.googlesource.com/c/486439/

BUG= 714926 
TEST=./validate_format.py && ./pretty_print.py

Review-Url: https://codereview.chromium.org/2842723002
Cr-Commit-Position: refs/heads/master@{#467857}

[modify] https://crrev.com/77a4bd9d48145f782e8cc1f3f2f6788001f33060/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d2694dd116de79e905a1d35e68e20b2f384011e9

commit d2694dd116de79e905a1d35e68e20b2f384011e9
Author: Dan Spaid <dspaid@google.com>
Date: Fri Apr 28 05:54:52 2017

cryptohome: Add UMA stats for encryption type

Add UMA stats for tracking how many users are on ecryptfs versus
ext4-crypto.
Histograms to be added in chromium with
https://codereview.chromium.org/2842723002/

BUG= chromium:714926 
TEST=cros_workon_make --board=samus --test cryptohome

Change-Id: I85fec267e8e03be13a91d598deec5992f82ba585
Reviewed-on: https://chromium-review.googlesource.com/486439
Commit-Ready: Dan Spaid <dspaid@chromium.org>
Tested-by: Dan Spaid <dspaid@chromium.org>
Reviewed-by: Dan Spaid <dspaid@chromium.org>

[modify] https://crrev.com/d2694dd116de79e905a1d35e68e20b2f384011e9/cryptohome/mount.cc
[modify] https://crrev.com/d2694dd116de79e905a1d35e68e20b2f384011e9/cryptohome/cryptohome_metrics.cc
[modify] https://crrev.com/d2694dd116de79e905a1d35e68e20b2f384011e9/cryptohome/cryptohome_metrics.h

Labels: Merge-Request-59
Project Member

Comment 6 by sheriffbot@chromium.org, May 1 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, May 1 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/68f034a9c88a674611e116a007e59103ecc49c5c

commit 68f034a9c88a674611e116a007e59103ecc49c5c
Author: Dan Spaid <dspaid@google.com>
Date: Mon May 01 02:02:21 2017

cryptohome: Add UMA stats for encryption type

Add UMA stats for tracking how many users are on ecryptfs versus
ext4-crypto.
Histograms to be added in chromium with
https://codereview.chromium.org/2842723002/
Cherry-pick to M59 at https://codereview.chromium.org/2852903002/

BUG= chromium:714926 
TEST=cros_workon_make --board=samus --test cryptohome

Change-Id: I85fec267e8e03be13a91d598deec5992f82ba585
Reviewed-on: https://chromium-review.googlesource.com/486439
Commit-Ready: Dan Spaid <dspaid@chromium.org>
Tested-by: Dan Spaid <dspaid@chromium.org>
Reviewed-by: Dan Spaid <dspaid@chromium.org>
(cherry picked from commit d2694dd116de79e905a1d35e68e20b2f384011e9)
Reviewed-on: https://chromium-review.googlesource.com/491008
Commit-Queue: Dan Spaid <dspaid@chromium.org>
Trybot-Ready: Dan Spaid <dspaid@chromium.org>

[modify] https://crrev.com/68f034a9c88a674611e116a007e59103ecc49c5c/cryptohome/mount.cc
[modify] https://crrev.com/68f034a9c88a674611e116a007e59103ecc49c5c/cryptohome/cryptohome_metrics.cc
[modify] https://crrev.com/68f034a9c88a674611e116a007e59103ecc49c5c/cryptohome/cryptohome_metrics.h

Project Member

Comment 8 by bugdroid1@chromium.org, May 1 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af597cf8c1a2377519955cd29965ac9c97d321e2

commit af597cf8c1a2377519955cd29965ac9c97d321e2
Author: dspaid <dspaid@chromium.org>
Date: Mon May 01 04:34:25 2017

Add UMA stats for chroemos homedir encryption type

Add a metric to track the type of encryption used by chromeos user
homedirectories.
This histogram is added in chromeos at https://chromium-review.googlesource.com/c/486439/
It is being cherry-picked to M59 at https://chromium-review.googlesource.com/c/491008

BUG= 714926 
TEST=./validate_format.py && ./pretty_print.py
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2842723002
Cr-Commit-Position: refs/heads/master@{#467857}
(cherry picked from commit 77a4bd9d48145f782e8cc1f3f2f6788001f33060)

Review-Url: https://codereview.chromium.org/2852903002
Cr-Commit-Position: refs/branch-heads/3071@{#316}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/af597cf8c1a2377519955cd29965ac9c97d321e2/tools/metrics/histograms/histograms.xml

Comment 9 by uekawa@google.com, May 10 2017

Status: Fixed (was: Started)
assuming fixed.
Cc: dhadd...@chromium.org
Labels: UMAstats

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment