New issue
Advanced search Search tips

Issue 714925 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

"Recently closed" category of JumpList won't show up until closing three websites instead of one

Project Member Reported by chengx@chromium.org, Apr 25 2017

Issue description

Chrome Version: 59.0.3071.15 (Official Build) dev (64-bit) (cohort: Dev)
OS: Win10

What steps will reproduce the problem?
(1) Close all Chrome tabs.
(2) Delete all Jumplist icons in 
C:\Users\<account>\AppData\Local\Google\Chrome\User Data\Default\JumpListIcons.
(3) Restart Chrome and wait for a few second.
(4) Right click the Chrome icon in the Windows taskbar where a JumpList shows up. It has the "Most visited" category but not the "Recently closed" category.
(5) Open two "New Tab" tabs.
(6) Open whatever website in one tab, e.g., https://www.google.com/ and close it. Wait for 3.5+ seconds for the JumpList update to take place.
(7) Right click the Chrome icon in the Windows taskbar again.

What is the expected result?
The "Recently closed" category should appear in the JumpList and contain the website which is just closed.

What happens instead?
The "Recently closed" category doesn't show up until closing three websites, and it only shows the last closed website instead of all three.



 

Comment 1 Deleted

Comment 2 by chengx@chromium.org, Apr 25 2017

Cc: gab@chromium.org brucedaw...@chromium.org grt@chromium.org
Components: Internals>PlatformIntegration UI

Comment 3 by chengx@chromium.org, Apr 25 2017

Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b60799e04934ed8a06d47beafffd1d28b995915f

commit b60799e04934ed8a06d47beafffd1d28b995915f
Author: chengx <chengx@chromium.org>
Date: Tue Apr 25 20:25:51 2017

Fix the number of JumpList slots assigned to each JumpList category

By default, the maximum number of items to display in JumpList is 10
per Windows. Previously, we considered there'are 10 available JumpList
slots, and we assign these slots to "Most visit" and "Recently closed"
categories accordingly. However, each category title takes one slot.
Therefore, the number of JumpList slots assigned to each category is
incorrect. This caused  bug 714925 , "Recently closed category of
JumpList won't show up until closing three websites instead of one".

To fix this, we need to adjust the number of available JumpList slots
based on the presence of the two JumpList categories. If one of the
categories presents, there'll be one available slot less. If both
categories present, there'll be two available slots less.

Since now the number of available slots is 1 or 2 less as it should
be, we're now deleting and creating 1 or 2 less icons per JumpList
update. This saves some disk IO. Note that the current implementation
deletes 10 icons followed by creating 10 icons per JumpList update.

BUG= 714925 ,  40407 ,  179576 

Review-Url: https://codereview.chromium.org/2844463003
Cr-Commit-Position: refs/heads/master@{#467094}

[modify] https://crrev.com/b60799e04934ed8a06d47beafffd1d28b995915f/chrome/browser/win/jumplist.cc

Comment 5 by chengx@chromium.org, Apr 25 2017

Status: Fixed (was: Assigned)

Sign in to add a comment