Add Metrics to quantify how many PDFs show a blank placeholder or trigger a drive-by download
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e57c73a2db2ce7fad847d8663748d387fe545390 commit e57c73a2db2ce7fad847d8663748d387fe545390 Author: tommycli <tommycli@chromium.org> Date: Mon May 08 21:18:06 2017 PDF: Add UMA to track successful / failed PDF loads This CL covers successful loads of the internal PDF plugin, as well as when we show the plugin placeholder for the PDF (when user is on Android or the plugin is disabled and there is no fallback content). This CL does not cover the drive-by download or main-frame download cases. Those will be in a followup CL. BUG= 714917 Review-Url: https://codereview.chromium.org/2852193002 Cr-Commit-Position: refs/heads/master@{#470130} [modify] https://crrev.com/e57c73a2db2ce7fad847d8663748d387fe545390/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/e57c73a2db2ce7fad847d8663748d387fe545390/chrome/renderer/plugins/plugin_uma.cc [modify] https://crrev.com/e57c73a2db2ce7fad847d8663748d387fe545390/chrome/renderer/plugins/plugin_uma.h [modify] https://crrev.com/e57c73a2db2ce7fad847d8663748d387fe545390/tools/metrics/histograms/enums.xml [modify] https://crrev.com/e57c73a2db2ce7fad847d8663748d387fe545390/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c173ef62237c56354fd42882ea0999cc5564ef1c commit c173ef62237c56354fd42882ea0999cc5564ef1c Author: tommycli <tommycli@chromium.org> Date: Sat May 27 02:19:59 2017 PDF: Add UMA to track embedded PDF triggered drive-by downloads. Adds an entry to an existing histogram to track drive-by downloads triggered when the user views a page with an embedded PDF but has no PDF plugin (or it's disabled). BUG= 714917 Review-Url: https://codereview.chromium.org/2901563003 Cr-Commit-Position: refs/heads/master@{#475220} [modify] https://crrev.com/c173ef62237c56354fd42882ea0999cc5564ef1c/chrome/browser/download/chrome_download_manager_delegate.cc [modify] https://crrev.com/c173ef62237c56354fd42882ea0999cc5564ef1c/chrome/common/BUILD.gn [add] https://crrev.com/c173ef62237c56354fd42882ea0999cc5564ef1c/chrome/common/pdf_uma.cc [add] https://crrev.com/c173ef62237c56354fd42882ea0999cc5564ef1c/chrome/common/pdf_uma.h [modify] https://crrev.com/c173ef62237c56354fd42882ea0999cc5564ef1c/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/c173ef62237c56354fd42882ea0999cc5564ef1c/chrome/renderer/plugins/plugin_uma.cc [modify] https://crrev.com/c173ef62237c56354fd42882ea0999cc5564ef1c/chrome/renderer/plugins/plugin_uma.h [modify] https://crrev.com/c173ef62237c56354fd42882ea0999cc5564ef1c/tools/metrics/histograms/enums.xml
Bouncing this bug over to amberwon@ who's working on this area.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f56d8f43cd26e94d823f92d319bb3e653bb2d57e commit f56d8f43cd26e94d823f92d319bb3e653bb2d57e Author: Amber Won <amberwon@google.com> Date: Thu Aug 31 22:29:40 2017 Add UMA to track disabled PDF iframe loads and clicks to view PDF. Track PDF iframe loads when no PDF viewer is available and clicks to view PDF on the PDF plugin placeholder. Bug: 714917 Change-Id: I97643c9a7d1eee683b98a35e0b015b62a3664050 Reviewed-on: https://chromium-review.googlesource.com/636197 Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Amber Won <amberwon@google.com> Cr-Commit-Position: refs/heads/master@{#499050} [modify] https://crrev.com/f56d8f43cd26e94d823f92d319bb3e653bb2d57e/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/f56d8f43cd26e94d823f92d319bb3e653bb2d57e/chrome/browser/plugins/pdf_iframe_navigation_throttle.cc [modify] https://crrev.com/f56d8f43cd26e94d823f92d319bb3e653bb2d57e/chrome/browser/plugins/pdf_iframe_navigation_throttle_unittest.cc [modify] https://crrev.com/f56d8f43cd26e94d823f92d319bb3e653bb2d57e/chrome/common/pdf_uma.h [modify] https://crrev.com/f56d8f43cd26e94d823f92d319bb3e653bb2d57e/chrome/renderer/plugins/pdf_plugin_placeholder.cc [modify] https://crrev.com/f56d8f43cd26e94d823f92d319bb3e653bb2d57e/tools/metrics/histograms/enums.xml [modify] https://crrev.com/f56d8f43cd26e94d823f92d319bb3e653bb2d57e/tools/metrics/histograms/histograms.xml
The assigned owner "amberwon@google.com" is not able to receive e-mails, please re-triage. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Comment 1 by bugdroid1@chromium.org
, May 8 2017