Issue metadata
Sign in to add a comment
|
12.3% regression in blink_perf.bindings at 466487:466508 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 25 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8981385089204313680
,
Apr 25 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8981385079874010624
,
Apr 26 2017
=== BISECT JOB RESULTS === Bisect failed for unknown reasons Please contact the team (see below) and report the error. Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : blink_perf.bindings Metric : node-type/node-type To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8981385089204313680 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5327728728866816 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 26 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8981286024819463856
,
Apr 26 2017
=== Auto-CCing suspected CL author meacer@chromium.org === Hi meacer@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : meacer Commit : ba52f56207a4b9d70b34880fbff2352e71a06422 Date : Sat Apr 22 00:08:08 2017 Subject: Block renderer-initiated main frame navigations to data URLs Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : blink_perf.bindings Metric : node-type/node-type Change : 7.09% | 235.138184316 -> 218.468471325 Revision Result N chromium@466486 235.138 +- 1.35273 6 good chromium@466503 236.384 +- 15.5745 6 good chromium@466504 226.329 +- 1.18986 6 bad <-- chromium@466505 226.383 +- 1.92509 6 bad chromium@466506 226.546 +- 1.02397 6 bad chromium@466508 226.253 +- 1.21762 6 bad chromium@466512 223.556 +- 11.6603 6 bad chromium@466520 218.468 +- 5.39423 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8981385079874010624 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5838335278317568 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 26 2017
=== BISECT JOB RESULTS === Bisect failed for unknown reasons Please contact the team (see below) and report the error. Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : blink_perf.bindings Metric : node-type/node-type To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8981286024819463856 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5327728728866816 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 27 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8981117079515691664
,
Apr 29 2017
=== BISECT JOB RESULTS === Bisect failed for unknown reasons Please contact the team (see below) and report the error. Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : blink_perf.bindings Metric : node-type/node-type To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8981117079515691664 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5327728728866816 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
May 3 2017
,
Jul 27 2017
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md We're looking for one of the following: 1. Justification via explanation 2. Plan to revert or fix 3. Angry rage throwing of equipment at my head Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it. Note: This was a bulk edit message and not very personal.
,
Sep 14 2017
meacer: any update here? cc-ing blink_perf.bindings owner jbroman: another old bug the cl author didn't respond to. Anything we can do at this point?
,
Sep 14 2017
Sorry, no updates in terms of fixing the regression, but I can try to explain the change: Webview can use data URIs to populate its contents. With ba52f56207a4b9d70b34880fbff2352e71a06422, we have an extra code path that decides whether the data URL should be allowed or blocked. This code path is probably what's introducing the perf hit, but we don't do any decoding or other heavy operation on the data URI, so the 12% regression looks pretty odd to me.
,
Sep 18 2017
+jbroman, owner of blink_perf.bindings. Does this regression sound acceptable?
,
Sep 20 2017
,
Jan 5 2018
WontFixing since it seems the regression is acceptable. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by rsch...@chromium.org
, Apr 25 2017