Autocomplete Not Presenting Relevant Results |
|||||
Issue descriptionWhen I search for browser_view.h (or other direct file hits), they don't show up in the autocomplete top hits: Query: browser_view.h (or even browser_view\.h) Results: test_with_browser_view.h find_bar_view.cc tab.cc toolbar_view.cc tab_scrubber_browsertest.cc bookmark_bar_view.cc omnibox_view_views_browsertest.cc I would expect a top hit of browser_view.h located at src/chrome/browser/ui/views/frame/browser_view.h A query of "file:browser_view.h" however, does have a hit, so autocomplete should know about the result.
,
Apr 25 2017
Thanks for the report. I can reproduce this problem and this looks like an odd bug. I'm not sure why it would show some results from the same directory but not for this file.
,
May 13 2017
These results can lead to thinking that a class isn't in the tree when it actually is, which led to some wasted time by myself and Walter today. For example, searching for "layer.cc" returns only two results in the quick dropdown box (focus_ring_layer.cc and BoxPainter.h) and it's only when you go to the full results that cc/layer.cc is found. This is a new-ish regression and, IIRC, started around when this bug was filed. I looked through the codesearch changes around that range and couldn't find any smoking guns. I hit this bug daily :( Could this be prioritized?
,
May 15 2017
nick@ and I have been hitting this a lot recently. It doesn't show results for "web_contents_impl.h". It also points to src/out/Debug/gen for "registry_controlled_domains", which is unexpected.
,
May 15 2017
Sorry for these issues and for the delay. I haven't had time to investigate this further yet but I will try to do so tomorrow.
,
May 16 2017
Running this locally I can't reproduce the problem, which means the next release should resolved the issue. If you go to cs-staging.chromium.org you should see results. This release should go out to prod very soon, hopefully today. I'll investigate further to see what change may have caused this.
,
May 16 2017
This issue turned out to be a little bit more severe than expected but the current prod instance should have a temporary fix. We are working on fixing the underlying problem and we will update the prod instances when that is ready. Please let us know if you still see the issue.
,
May 16 2017
Re #4 and #7: Yes, web_contents_impl.h and registry_controlled_domains are both working properly in autocomplete now. browser_view.h looks good, too. Thanks!
,
May 17 2017
Closing this issue. Please re-open if you are still seeing the problem. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by robliao@chromium.org
, Apr 25 201738.0 KB
38.0 KB View Download