New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714860 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Email to this user bounced
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 708815



Sign in to add a comment

Ampersands need to be stripped from menu text

Project Member Reported by a...@chromium.org, Apr 24 2017

Issue description

Version 60.0.3079.0 (Official Build) canary (64-bit)

has in the Bookmarks menu:

"&Open All"
"Open All (x) in &New Window"
"Open All (x) in &Incognito Window"

You need to strip the & from the menu titles.

You probably switched from l10n_util_mac.h's GetNSStringFWithFixup to GetPluralNSStringF, but that loses the fixup. You need to manually call FixUpWindowsStyleLabel.
 
Screen Shot 2017-04-24 at 7.28.31 PM.png
34.0 KB View Download

Comment 1 by a...@chromium.org, Apr 24 2017

Blocking: 708815

Comment 2 by lgrey@chromium.org, Apr 25 2017

avi@ is this obviated by  crbug.com/708813  (in today's Canary)?

Comment 3 by a...@chromium.org, Apr 25 2017

Status: WontFix (was: Assigned)
Obviated.
Cc: msrchandra@chromium.org paezagon@chromium.org ranjitkan@chromium.org rbasuvula@chromium.org nyerramilli@chromium.org
 Issue 713661  has been merged into this issue.

Sign in to add a comment