New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714859 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-05-04
OS: Mac
Pri: 1
Type: Bug
Team-Security-UX



Sign in to add a comment

Page Info Cocoa: decision strings are misaligned in RTL

Project Member Reported by lgar...@chromium.org, Apr 24 2017

Issue description

Chrome 60.0.3080.0
OSX 10.12.4

What steps will reproduce the problem?
(1) Open Chrome in Arabic or Hebrew
(2) Trigger permission embargo for a site
(3) Open Page Info

What is the expected result?
The permission decision for embargo is right-aligned with the permission label.

What happens instead?
The permission decision string is *left*-aligned with the permission label (see screenshots).

Patti, could you investigate getting a fix into M59 for our RTL users?
 
Screen Shot 2017-04-24 at 16.27.38.png
143 KB View Download
Screen Shot 2017-04-21 at 16.50.09.png
498 KB View Download
Status: Started (was: Assigned)
Started at https://codereview.chromium.org/2841013002/

Thanks Lucas for reporting this!
Thanks for tackling it quickly!

Could you post a screenshot rebased on tip of tree (I fixed vertical alignment), and one with an overflowing RTL string?
I wasn't able to find a string that actually overflowed the width of the bubble, so I used a temporary one - hopefully it's enough to show the overflow behaviour.
fixed page info bubble rtl.png
91.6 KB View Download
re #3: Thanks, that looks good!

I also tested in a Hebrew sting once, so I think that will look okay.
Project Member

Comment 5 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09eed0675cc8f316344caf5ac695f140608493f6

commit 09eed0675cc8f316344caf5ac695f140608493f6
Author: patricialor <patricialor@chromium.org>
Date: Tue May 02 05:31:13 2017

Permissions/Mac: Fix RTL positions for permission decision strings.

Support RTL for permission decision strings, wrapping strings that may be too
long to fit.

See
https://drive.google.com/file/d/0BzEa5HU1aAqBUEl4THZuSkd5Tms/view?usp=sharing
for before / after screenshots.

BUG= 714859 

Review-Url: https://codereview.chromium.org/2841013002
Cr-Commit-Position: refs/heads/master@{#468568}

[modify] https://crrev.com/09eed0675cc8f316344caf5ac695f140608493f6/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm

Labels: Merge-Request-59
Labels: -Merge-Request-59
NextAction: 2017-05-04
Status: Fixed (was: Started)
Oops, I'll verify this in Canary first before requesting a merge.
Labels: Merge-Request-59
Status: Started (was: Fixed)
Verified in Canary 60.0.3088.3.
Project Member

Comment 10 by sheriffbot@chromium.org, May 4 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, May 4 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2568622961b5a63769ea033d535d45a18053c503

commit 2568622961b5a63769ea033d535d45a18053c503
Author: Patricia Lor <patricialor@chromium.org>
Date: Thu May 04 04:47:20 2017

Permissions/Mac: Fix RTL positions for permission decision strings.

Support RTL for permission decision strings, wrapping strings that may be too
long to fit.

See
https://drive.google.com/file/d/0BzEa5HU1aAqBUEl4THZuSkd5Tms/view?usp=sharing
for before / after screenshots.

BUG= 714859 

Review-Url: https://codereview.chromium.org/2841013002
Cr-Commit-Position: refs/heads/master@{#468568}
(cherry picked from commit 09eed0675cc8f316344caf5ac695f140608493f6)

Review-Url: https://codereview.chromium.org/2859103003 .
Cr-Commit-Position: refs/branch-heads/3071@{#394}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/2568622961b5a63769ea033d535d45a18053c503/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm

Status: Fixed (was: Started)
Cc: sureshkumari@chromium.org
Labels: Needs-Feedback
Tested the issue on Mac-10.12.4 using chrome version 59.0.3071.47 with the steps mentioned in comment#0.

patricialor@ Please find the attached screencast and screenshot and please confirm the expected behavior.

Thanks.

714859.mov
2.4 MB Download
Mac-714859.png
81.1 KB View Download
Oh, the screenshot / screencast in #c13 doesn't actually show the string that had the RTL issue. I guess step #2 in the bug description should have been expanded a bit more, here are the full repro steps:

1. Run Chrome with the command line flag --enable-features=BlockPromptsIfDismissedOften
2. Navigate to https://permission.site.
3. Click the "Notifications" button, observe the permission prompt appeared under the omnibox, then press escape to close it.
4. Repeat step #3. On the fourth click, the prompt will not appear again.
5. Open the page info bubble by clicking on the "Secure" text in the omnibox. Observe there is text underneath the notifications permission, which should be RTL and span the entire width of the page info bubble. Long translations here should also wrap onto the next line.

Apologies for the confusion! The strings should also be shown for permissions controlled by enterprise policy or an extension, so installing an extension to turn off Javascript should also show it.

Sign in to add a comment