Issue 714847 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	eroman@chromium.org
Closed:	Apr 2017
Components:	Blink>WebCrypto
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

In Web Crypto, deriveBits() for HKDF with a non-multiple of 8 should throw an OperationError

Project Member Reported by eroman@chromium.org, Apr 24 2017

Issue description

See https://codereview.chromium.org/2838603002/ for context, which points out the problem.

This isn't detailed in the spec, but that is likely a spec bug:
  https://github.com/w3c/webcrypto/issues/184 for spec

Based on how PBKDF2 is defined, and the general philosophy that enforcements on bit-lengths be handled internal to the algorithm, and the W3C test itself, it is fairly clear that the intent is to throw an error when HKDF is called with a non-multiple of 8 bits.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4451821b58a52fce62d9a5d197eef2e8d7dac949

commit 4451821b58a52fce62d9a5d197eef2e8d7dac949
Author: eroman <eroman@chromium.org>
Date: Wed Apr 26 19:30:24 2017

Raise an error when calling WebCrypto's deriveBits() for HKDF with
non-multiple of 8 length.

BUG= 714847 

Review-Url: https://codereview.chromium.org/2837383002
Cr-Commit-Position: refs/heads/master@{#467411}

[modify] https://crrev.com/4451821b58a52fce62d9a5d197eef2e8d7dac949/components/webcrypto/algorithms/hkdf.cc
[modify] https://crrev.com/4451821b58a52fce62d9a5d197eef2e8d7dac949/components/webcrypto/status.cc
[modify] https://crrev.com/4451821b58a52fce62d9a5d197eef2e8d7dac949/components/webcrypto/status.h
[modify] https://crrev.com/4451821b58a52fce62d9a5d197eef2e8d7dac949/third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits-expected.txt
[modify] https://crrev.com/4451821b58a52fce62d9a5d197eef2e8d7dac949/third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits-failures-expected.txt
[modify] https://crrev.com/4451821b58a52fce62d9a5d197eef2e8d7dac949/third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits-failures.html
[modify] https://crrev.com/4451821b58a52fce62d9a5d197eef2e8d7dac949/third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits.html

Comment 2 by eroman@chromium.org, Apr 28 2017

Status: Fixed (was: Assigned)

Side note: I didn't end up having to rebase WPT tests, making me wonder if those tests are even running at all, or just in a manner I don't understand...

Will check that out, but otherwise this is fixed.

►

Issue 714847 link

Issue metadata

In Web Crypto, deriveBits() for HKDF with a non-multiple of 8 should throw an OperationError

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 26 2017

Comment 1 Deleted

Comment 2 by eroman@chromium.org, Apr 28 2017

Comment 2 Deleted

Sign in to add a comment