[Sync] Remove required from SyncEntity proto |
||
Issue descriptionWe currently have two required fields in SyncEntity: name and version. When emitting user events, we want to be as compact as possible, and being forced to set empty fields conflicts with this. It should be possible to update the client and server definitions to simply treat these fields as optional going forward. Old clients will still think they're required, and it's important that they always receive values for these. On non-commit only model types we should still be setting these for the foreseeable future. We could also add a safety check to the server side to make sure old clients always see these fields as well, to prevent a regression.
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9bf5ca85577c34702afe733dcb6d1d98ed728a0 commit f9bf5ca85577c34702afe733dcb6d1d98ed728a0 Author: skym <skym@chromium.org> Date: Fri Apr 28 20:06:39 2017 [Sync] Remove required fields from SyncEntity and obsolete ThrottleParameters. This in preparation for USER_EVENTS, which is a commit only type and some fields like version and not useful. We want to save as much bandwidth as possible, and switching to optional saves us ~2 bytes each before compression. BUG= 714828 Review-Url: https://codereview.chromium.org/2837993002 Cr-Commit-Position: refs/heads/master@{#468104} [modify] https://crrev.com/f9bf5ca85577c34702afe733dcb6d1d98ed728a0/components/sync/protocol/sync.proto
,
Apr 28 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by s...@chromium.org
, Apr 27 2017