New issue
Advanced search Search tips

Issue 714825 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task



Sign in to add a comment

Six broken image rendering layout tests failing on SPv2.

Project Member Reported by wkorman@chromium.org, Apr 24 2017

Issue description

Noted at ToT. Looks like introduced around build 4000 which is the first showing these failures:

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_slimming_paint_v2/builds/4000

Regressions: Unexpected image-only failures (6)
  images/rendering-broken-10px-images.html [ Failure ]
  images/rendering-broken-16px-images.html [ Failure ]
  images/rendering-broken-1px-images.html [ Failure ]
  images/rendering-broken-block-flow-images.html [ Failure ]
  images/rendering-broken-images-empty-alt.html [ Failure ]
  images/rendering-broken-images.html [ Failure ]

 
Labels: -Type-Bug Type-Task
Build 3999 passed CQ but does not show these failures:

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_slimming_paint_v2/builds/3999

And the involved change does not look like it would affect: https://codereview.chromium.org/2584143003

So am guessing some other change went in around this time and didn't run SPv2 bot.
In case the build metadata vanishes, build 4000 start timestamp is Sun Apr 23 05:32:28 2017.
Cc: robhogan@chromium.org
These tests are new and were added on Sat in https://codereview.chromium.org/2593263003

It looks like the content is just wrapping too soon. Suspect it is a general layout/width computation issue (re: "non-replaced inline container" as noted in change description) and probably present in other still-failing-in-SPv2 tests and not necessarily specific to the logic in the change that added them.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d2e34227539941772c3243cc0d5b31e09b88d01

commit 0d2e34227539941772c3243cc0d5b31e09b88d01
Author: wkorman <wkorman@chromium.org>
Date: Tue Apr 25 00:21:21 2017

Disable broken image layout tests failing under SPv2.

BUG= 714825 
TBR=pdr@chromium.org

Review-Url: https://codereview.chromium.org/2838623003
Cr-Commit-Position: refs/heads/master@{#466834}

[modify] https://crrev.com/0d2e34227539941772c3243cc0d5b31e09b88d01/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2

Labels: -OS-All Test-Layout BugSource-Team PaintTeamTriaged-20170425 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: ----
Status: Available (was: Assigned)
Unassigning self from bugs that I don't expect to be able to get to soon in case someone else is able to pick them up.
Project Member

Comment 8 by sheriffbot@chromium.org, May 14 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -robhogan@chromium.org
Status: Available (was: Untriaged)
Status: Fixed (was: Available)
The tests are passing and the failure expectations have been removed.

Sign in to add a comment