MD Settings: Certificates: Can not bind certificate with empty password |
||||||||
Issue descriptionVersion: Chrome @466630 Repro: 1. Visit chrome://md-settings/certificates 2 Click 'Import and bind' 3. Select a .p12 certificate with an empty password Observe: 'Enter your certificate password' dialog has 'OK' button disabled Expected: In chrome://settings-frame, the equivalent dialog allows an empty password and successfully imports the certificate
,
Apr 24 2017
I'll take a look..
,
Apr 25 2017
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fcacd73cb3cca2e131fc8d94e3764744ecde23e commit 6fcacd73cb3cca2e131fc8d94e3764744ecde23e Author: dpapad <dpapad@chromium.org> Date: Tue Apr 25 01:40:38 2017 MD Settings: Allow empty passwords when importing certificate. BUG= 714824 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2836143004 Cr-Commit-Position: refs/heads/master@{#466861} [modify] https://crrev.com/6fcacd73cb3cca2e131fc8d94e3764744ecde23e/chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html [modify] https://crrev.com/6fcacd73cb3cca2e131fc8d94e3764744ecde23e/chrome/test/data/webui/settings/certificate_manager_page_test.js
,
Apr 25 2017
,
Apr 25 2017
This could be a problem for folks installing certificates for networks on CrOS so we should merge this to 59. (It's also a small, safe change).
,
Apr 26 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 26 2017
dpapad@ - I am merging this now.
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05516894f9cfb4449cde17708a707a4dd75fac77 commit 05516894f9cfb4449cde17708a707a4dd75fac77 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Apr 26 16:12:54 2017 MD Settings: Allow empty passwords when importing certificate. BUG= 714824 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2836143004 Cr-Commit-Position: refs/heads/master@{#466861} (cherry picked from commit 6fcacd73cb3cca2e131fc8d94e3764744ecde23e) Review-Url: https://codereview.chromium.org/2845673002 . Cr-Commit-Position: refs/branch-heads/3071@{#226} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/05516894f9cfb4449cde17708a707a4dd75fac77/chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html [modify] https://crrev.com/05516894f9cfb4449cde17708a707a4dd75fac77/chrome/test/data/webui/settings/certificate_manager_page_test.js
,
Apr 28 2017
Issue 716275 has been merged into this issue.
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by steve...@chromium.org
, Apr 24 2017