For issues like bug 714692 , it will be helpful if NetLog tells us what the invalid H2 response headers are.
Bence, what is the best approach here? Can we add NetLog events directly in HeaderCoalescer? Is there a more appropriate place for logging?
Yes, it is perfectly fine to add NetLog to HeaderCoalescer. Sorry for the slow response.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/435f1fb7295f9f3cf235c1447fab59d49acc805f commit 435f1fb7295f9f3cf235c1447fab59d49acc805f Author: xunjieli <xunjieli@chromium.org> Date: Wed May 10 20:35:42 2017 Add NetLog event for invalid Http/2 response header BUG= 714809 Review-Url: https://codereview.chromium.org/2847133003 Cr-Commit-Position: refs/heads/master@{#470691} [modify] https://crrev.com/435f1fb7295f9f3cf235c1447fab59d49acc805f/net/log/net_log_event_type_list.h [modify] https://crrev.com/435f1fb7295f9f3cf235c1447fab59d49acc805f/net/spdy/chromium/buffered_spdy_framer.cc [modify] https://crrev.com/435f1fb7295f9f3cf235c1447fab59d49acc805f/net/spdy/chromium/buffered_spdy_framer.h [modify] https://crrev.com/435f1fb7295f9f3cf235c1447fab59d49acc805f/net/spdy/chromium/buffered_spdy_framer_unittest.cc [modify] https://crrev.com/435f1fb7295f9f3cf235c1447fab59d49acc805f/net/spdy/chromium/header_coalescer.cc [modify] https://crrev.com/435f1fb7295f9f3cf235c1447fab59d49acc805f/net/spdy/chromium/header_coalescer.h [modify] https://crrev.com/435f1fb7295f9f3cf235c1447fab59d49acc805f/net/spdy/chromium/header_coalescer_test.cc [modify] https://crrev.com/435f1fb7295f9f3cf235c1447fab59d49acc805f/net/spdy/chromium/spdy_session.cc [modify] https://crrev.com/435f1fb7295f9f3cf235c1447fab59d49acc805f/net/spdy/chromium/spdy_session.h [modify] https://crrev.com/435f1fb7295f9f3cf235c1447fab59d49acc805f/net/spdy/chromium/spdy_session_unittest.cc [modify] https://crrev.com/435f1fb7295f9f3cf235c1447fab59d49acc805f/net/spdy/chromium/spdy_test_util_common.cc
Comment 1 by xunji...@chromium.org
, Apr 24 2017