mash: Screen Lock does not take fullscreen |
|||||
Issue descriptionLockWindow is created with ui::SHOW_STATE_FULLSCREEN [1] and set to the bounds of primary display bounds [2]. This works in classic ash but not in mash. In mash, LockWindow is adjusted to only fill the workspace. See attached screenshot and note the footer bar is at wrong position. [1]: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/ui/lock_window.cc?rcl=2cac5e68544bf2f5fbaec00f62ffe0c6e7957598&l=21 [2]: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/lock/webui_screen_locker.cc?rcl=15ccd14cb45a2e1b82de13d4fec1803f6521053b&l=152,162
,
Apr 25 2017
Mus window fullscreen is set via WindowManager::kShowState_Property.
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1ad8f0a9e80c7b864f432fb4cdbb6f987de53fb commit c1ad8f0a9e80c7b864f432fb4cdbb6f987de53fb Author: xiyuan <xiyuan@chromium.org> Date: Thu Apr 27 03:45:44 2017 mash: Fix create fullscreen widget Set kShowStateKey property from init params show_state so that mus window is created properly. BUG= 714804 TEST=DesktopWindowTreeHostMusTest.CreateFullscreenWidget Review-Url: https://codereview.chromium.org/2840903002 Cr-Commit-Position: refs/heads/master@{#467572} [modify] https://crrev.com/c1ad8f0a9e80c7b864f432fb4cdbb6f987de53fb/ui/views/mus/desktop_window_tree_host_mus.cc [modify] https://crrev.com/c1ad8f0a9e80c7b864f432fb4cdbb6f987de53fb/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
,
Apr 27 2017
,
Aug 1 2017
,
Jan 22 2018
,
Feb 26 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by xiy...@chromium.org
, Apr 24 2017