New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714803 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

SharedPageStateTests.testPageStatesUserAgentType fails on x64-generic-telemetry, amd64-generic-telemetry

Project Member Reported by michae...@chromium.org, Apr 24 2017

Issue description

This test has been failing for at least several days:

04/24 12:54:39.349 INFO |run_chromeos_tests:0052| [626/1084] telemetry.page.shared_page_state_unittest.SharedPageStateTests.testPageStatesUserAgentType failed unexpectedly 0.0011s:
04/24 12:54:39.349 INFO |run_chromeos_tests:0052|   Traceback (most recent call last):
04/24 12:54:39.350 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/page/shared_page_state_unittest.py", line 86, in testPageStatesUserAgentType
04/24 12:54:39.350 INFO |run_chromeos_tests:0052|       shared_page_state.SharedDesktopPageState, 'desktop')
04/24 12:54:39.351 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/page/shared_page_state_unittest.py", line 80, in assertUserAgentSetCorrectly
04/24 12:54:39.351 INFO |run_chromeos_tests:0052|       self.assertEqual(expected_user_agent, actual_user_agent)
04/24 12:54:39.351 INFO |run_chromeos_tests:0052|   AssertionError: 'desktop' != 'chromeos'


 
Cc: michae...@chromium.org warx@chromium.org
Owner: cywang@chromium.org
Status: Assigned (was: Untriaged)
cywang: Might this test be failing due to https://github.com/catapult-project/catapult/commit/f7bb286d01fdbedf1f6dd5921d564ef5f0344cb4?

Comment 2 by cywang@chromium.org, Apr 25 2017

Could you provide more details about the failures? I did not see the error above from recent builds on https://luci-milo.appspot.com/buildbot/chromiumos.chromium/x86-generic-telemetry/ or https://luci-milo.appspot.com/buildbot/chromiumos.chromium/amd64-generic-telemetry/

Comment 3 by cywang@chromium.org, Apr 25 2017

Thanks for filing this bug, CL for fixing it - https://codereview.chromium.org/2838073002

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88d1d186845613b22258b6ad4eb168a4f63d8432

commit 88d1d186845613b22258b6ad4eb168a4f63d8432
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Fri Apr 28 05:52:26 2017

Roll src/third_party/catapult/ 9c9ac13a2..778079b34 (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9c9ac13a2b02..778079b344c8

$ git log 9c9ac13a2..778079b34 --date=short --no-merges --format='%ad %ae %s'
2017-04-27 cywang [shared_page_state] Fix unit test

Created with:
  roll-dep src/third_party/catapult
BUG= 714803 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ic1b8f579e35bc46cd6673b97b780404f11552abc
Reviewed-on: https://chromium-review.googlesource.com/489669
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467911}
[modify] https://crrev.com/88d1d186845613b22258b6ad4eb168a4f63d8432/DEPS

Cc: cywang@chromium.org
Owner: jen...@chromium.org
We still have failures in these tests, but they don't seem to be the same (maybe issue 702930?) -- assigning to current gardener to triage. Please close this bug if the errors from #1 are resolved.
Cc: achuith@chromium.org
The telementry bots have been failing for a long time for both bots in comment#4. achuith@, would you please take a look to see who we should assign this bug to?
Status: Fixed (was: Assigned)
Please create a new bug as SharedPageStateTests.testPageStatesUserAgentType test was fixed already - 
https://storage.cloud.google.com/chromeos-image-archive/x86-generic-telemetry/R60-9516.0.0-b12395/vm_test_results_1/telemetry_suite/test_harness/all/SimpleTestVerify/1_autotest_tests/results-3-telemetry_UnitTests/debug/client.0.DEBUG?_ga=1.140173489.360545000.1444731951. It seems better to track all other failures in issue 702930?

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment