Long-click + download on a page that results in interstitial error will quietly pause the download without any notification |
|||
Issue descriptionChrome build: tip of tree from 4/24 Repro steps: 1. Turn on downloading 2. navigate to badssl.com 3. long-press any of the links that should result in an error and select download link 4. Observe Expected behavior: the link (which is to a webpage) should trigger offline pages to handle it, and then user notified that the page loading failed (because it's an error page) Current behavior: this quietly creates a task called "download" and then quietly pauses it with no notification to user whatsoever Corresponding log statement, from jianli@ 04-24 13:48:17.602 14102 14102 E chromium: [ERROR:download_item_impl.cc(1984)] TransitionTo() from:INITIAL to:INTERRUPTED_TARGET_PENDING this = { id = 10 state = INTERRUPTED_TARGET_PENDING total = 0 received = 0 reason = NETWORK_FAILED paused = F resume_mode = USER_RESTART auto_resume_count = 0 danger = 0 all_data_saved = F last_modified = '' etag = '' has_download_file = false url_chain = 04-24 13:48:17.602 14102 14102 E chromium: "https://untrusted-root.badssl.com/" 04-24 13:48:17.602 14102 14102 E chromium: current_path = "" 04-24 13:48:17.602 14102 14102 E chromium: target_path = "" referrer = "https://badssl.com/" site_url = "https://badssl.com/" }
,
Apr 27 2017
It looks like the site isn't setting the correct mime-type. Min can verify.
,
Apr 27 2017
I see a crash on trunk while reproducing the issue, both desktop/android.
,
Apr 28 2017
There are 2 issues, 1. the mime type is unknown when you using context menu to download a link, so this cannot be handled by offline pages. 2. The download is interrupted at the beginning, we should show a download pending notification, but on Android we skipped that. I will fix 2 on android.
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81fb77eba496961aec989cc4945b3cf47f78fbf7 commit 81fb77eba496961aec989cc4945b3cf47f78fbf7 Author: qinmin <qinmin@chromium.org> Date: Mon May 01 18:10:11 2017 Fix an issue that notification is not posted if download is interrupted on start If a download is interrupted on start, notification is not posted. However, the download will show up in download home. This CL fixes the issue by allowing interrupted downloads to post new notifications. BUG= 714798 Review-Url: https://codereview.chromium.org/2848723004 Cr-Commit-Position: refs/heads/master@{#468355} [modify] https://crrev.com/81fb77eba496961aec989cc4945b3cf47f78fbf7/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java [modify] https://crrev.com/81fb77eba496961aec989cc4945b3cf47f78fbf7/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/81fb77eba496961aec989cc4945b3cf47f78fbf7/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java [modify] https://crrev.com/81fb77eba496961aec989cc4945b3cf47f78fbf7/chrome/browser/download/download_ui_controller.cc
,
May 18 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jianli@chromium.org
, Apr 24 2017