New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 714775 link

Starred by 1 user
Status: Fixed
Owner:
█ amp@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
iclell...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

WebVR origin trial broken on navigation

Project Member Reported by amp@chromium.org, Apr 24 2017 
The renaming of WebVR origin trial missed a name reference in the file that is required to make the API available dynamically.

Without it the trial will load all parts of the API if Chrome is started from scratch on that page, but navigations and reloads will not have the window level API's available.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67027f74a115a3d139b7ec92f0cc3d4a61fe6917

commit 67027f74a115a3d139b7ec92f0cc3d4a61fe6917
Author: amp <amp@chromium.org>
Date: Tue Apr 25 17:07:48 2017

Rename WebVR origin trial in conditional features

BUG= 714775 

Review-Url: https://codereview.chromium.org/2839753004
Cr-Commit-Position: refs/heads/master@{#467022}

[modify] https://crrev.com/67027f74a115a3d139b7ec92f0cc3d4a61fe6917/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp

Comment 2 by amp@chromium.org, Apr 25 2017

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 25 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7d198f532da6abc97e390e255c614a8987d4144

commit a7d198f532da6abc97e390e255c614a8987d4144
Author: amp <amp@chromium.org>
Date: Wed Apr 26 17:02:48 2017

Rename WebVR origin trial in conditional features

BUG= 714775 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2839753004
Cr-Commit-Position: refs/heads/master@{#467022}
(cherry picked from commit 67027f74a115a3d139b7ec92f0cc3d4a61fe6917)

Review-Url: https://codereview.chromium.org/2836293005
Cr-Commit-Position: refs/branch-heads/3071@{#228}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/a7d198f532da6abc97e390e255c614a8987d4144/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp

Comment 5 by amp@chromium.org, Apr 26 2017

Status: Fixed (was: Started)

Comment 6 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR
►

Sign in to add a comment