New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714772 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Threading violation in headless::HeadlessDevToolsManagerDelegate::HandleCommand

Project Member Reported by skyos...@chromium.org, Apr 24 2017

Issue description

To reproduce (in a debug build):

$ cr run headless_shell --deterministic-fetch http://www.hs.fi

[0424/210751.110496:FATAL:headless_devtools_manager_delegate.cc(120)] Check failed: ::content::BrowserThread::CurrentlyOn(content::BrowserThread::UI). Must be called on Chrome_UIThread; actually called on Chrome_IOThread.
#0 0x7f4e93b9535b base::debug::StackTrace::StackTrace()
#1 0x7f4e93b9405c base::debug::StackTrace::StackTrace()
#2 0x7f4e93c07773 logging::LogMessage::~LogMessage()
#3 0x7f4e94757129 headless::HeadlessDevToolsManagerDelegate::HandleCommand()
#4 0x7f4e8eeb02e7 content::DevToolsSession::Dispatch()
#5 0x7f4e8ef223b5 content::RenderFrameDevToolsAgentHost::DispatchProtocolMessage()
#6 0x7f4e8ee861b2 content::DevToolsAgentHostImpl::DispatchProtocolMessage()
#7 0x7f4e94754e59 headless::HeadlessDevToolsClientImpl::FinalizeAndSendMessage<>()
#8 0x7f4e94750b66 headless::HeadlessDevToolsClientImpl::SendMessageWithParams<>()
#9 0x7f4e9474f412 headless::HeadlessDevToolsClientImpl::SendMessage()
#10 0x7f4e94600d6e headless::page::ExperimentalDomain::ProcessNavigation()
#11 0x00000041be28 headless::ShellNavigationRequest::StartProcessing()
#12 0x7f4e9477d890 headless::DeterministicDispatcher::MaybeDispatchJobOnIOThreadTask()
#13 0x7f4e94783657 _ZN4base8internal13FunctorTraitsIMN8headless23DeterministicDispatcherEFvvEvE6InvokeIRKNS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_
#14 0x7f4e947835aa _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN8headless23DeterministicDispatcherEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_
#15 0x7f4e94783532 _ZN4base8internal7InvokerINS0_9BindStateIMN8headless23DeterministicDispatcherEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#16 0x7f4e9478347c _ZN4base8internal7InvokerINS0_9BindStateIMN8headless23DeterministicDispatcherEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#17 0x7f4e93b9b86e _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#18 0x7f4e93b9afae base::debug::TaskAnnotator::RunTask()
#19 0x7f4e93c2dc3d base::MessageLoop::RunTask()
#20 0x7f4e93c2dec4 base::MessageLoop::DeferOrRunPendingTask()
#21 0x7f4e93c2e1b4 base::MessageLoop::DoWork()
#22 0x7f4e93c487ae base::MessagePumpLibevent::Run()
#23 0x7f4e93c2d7d7 base::MessageLoop::RunHandler()
#24 0x7f4e93cd5ffa base::RunLoop::Run()
#25 0x7f4e93d7b9d4 base::Thread::Run()
#26 0x7f4e8edb8906 content::BrowserThreadImpl::IOThreadRun()
#27 0x7f4e8edb8c0b content::BrowserThreadImpl::Run()
#28 0x7f4e93d7c23a base::Thread::ThreadMain()
#29 0x7f4e93d62f6a base::(anonymous namespace)::ThreadFunc()
#30 0x7f4e94aff184 start_thread
#31 0x7f4e8cf07bed clone

 
Components: Internals>Headless
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4daa38647b9aca471e3cd1730977e1eb4b033dc0

commit 4daa38647b9aca471e3cd1730977e1eb4b033dc0
Author: Alex Clarke <alexclarke@chromium.org>
Date: Thu Aug 03 11:54:40 2017

Fix threading issues and make headless_shell listen to network domain

headless_shell --determinstic-fetch was totally borked. This seem to fix it.

Bug:  714772 
Change-Id: I4a6747a113cd999cb53fb1c1790761320a2b4035
Reviewed-on: https://chromium-review.googlesource.com/599947
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491703}
[modify] https://crrev.com/4daa38647b9aca471e3cd1730977e1eb4b033dc0/headless/app/headless_shell.cc
[modify] https://crrev.com/4daa38647b9aca471e3cd1730977e1eb4b033dc0/headless/app/shell_navigation_request.cc
[modify] https://crrev.com/4daa38647b9aca471e3cd1730977e1eb4b033dc0/headless/app/shell_navigation_request.h

Status: Fixed (was: Available)

Sign in to add a comment