New issue
Advanced search Search tips

Issue 714768 link

Starred by 1 user
Status: Verified
Owner:
mahmadi@chromium.org
Closed: Jun 2017
Cc:
se...@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

It should be impossible to pay with a card that has no billing address in iOS

Project Member Reported by se...@chromium.org, Apr 24 2017 
^^^

Comment 1 by mahmadi@chromium.org, Jun 22 2017

Cc: se...@chromium.org
Labels: -Pri-3 M-60 Pri-2
Status: Started (was: Available)

Comment 2 by rouslan@chromium.org, Jun 22 2017

Labels: -M-60 M-61

Comment 3 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43f2fb2e67d2d50f5134301a2a78d9d890bb6c61

commit 43f2fb2e67d2d50f5134301a2a78d9d890bb6c61
Author: mahmadi <mahmadi@chromium.org>
Date: Tue Jun 27 15:16:13 2017

[Payment Request] Makes sure only complete credit cards can be selected.

- Checks the credit cards for completeness before setting the default
  selected credit card.
- Allows selection of complete credit cards only.

BUG= 602666 ,  714768 

Review-Url: https://codereview.chromium.org/2956453003
Cr-Commit-Position: refs/heads/master@{#482629}

[modify] https://crrev.com/43f2fb2e67d2d50f5134301a2a78d9d890bb6c61/ios/chrome/browser/payments/payment_request.mm
[modify] https://crrev.com/43f2fb2e67d2d50f5134301a2a78d9d890bb6c61/ios/chrome/browser/payments/payment_request_unittest.mm
[modify] https://crrev.com/43f2fb2e67d2d50f5134301a2a78d9d890bb6c61/ios/chrome/browser/payments/payment_request_util.h
[modify] https://crrev.com/43f2fb2e67d2d50f5134301a2a78d9d890bb6c61/ios/chrome/browser/payments/payment_request_util.mm
[modify] https://crrev.com/43f2fb2e67d2d50f5134301a2a78d9d890bb6c61/ios/chrome/browser/ui/payments/payment_method_selection_coordinator.mm
[modify] https://crrev.com/43f2fb2e67d2d50f5134301a2a78d9d890bb6c61/ios/chrome/browser/ui/payments/payment_method_selection_coordinator_unittest.mm
[modify] https://crrev.com/43f2fb2e67d2d50f5134301a2a78d9d890bb6c61/ios/chrome/browser/ui/payments/payment_method_selection_mediator.mm
[modify] https://crrev.com/43f2fb2e67d2d50f5134301a2a78d9d890bb6c61/ios/chrome/browser/ui/payments/payment_request_coordinator.mm
[modify] https://crrev.com/43f2fb2e67d2d50f5134301a2a78d9d890bb6c61/ios/chrome/browser/ui/payments/payment_request_manager.mm
[modify] https://crrev.com/43f2fb2e67d2d50f5134301a2a78d9d890bb6c61/ios/chrome/browser/ui/payments/payment_request_mediator_unittest.mm

Comment 5 by mahmadi@chromium.org, Jun 27 2017

Status: Fixed (was: Started)

Comment 6 by subhashi...@chromium.org, Sep 4 2017

Status: Verified (was: Fixed)
Verified on :

App Version: 62.0.3202.7 canary
Devices: iPhone 7 Plus, iPadMini 2
iOS Versions: 10.3.3, 11.0

Only credit cards with complete information are selected by default. 

If the user selects credit cards missing some information, it shows a message 'Card billing address required', tapping on it allows user to select billing address.
CC_Info.PNG
152 KB View Download
►

Sign in to add a comment