New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714761 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
OOO until 2019-01-24
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 699566



Sign in to add a comment

Wrong guard in DCHECK code causes assertion failures only on Debug bots and not trybots

Project Member Reported by fjhenigman@chromium.org, Apr 24 2017

Issue description

The product of
Win10 Debug (NVIDIA), Win7 Debug (AMD), Win7 Debug (NVIDIA), Win7 x64 Debug (NVIDIA)
and
context_lost_tests, depth_capture_tests, pixel_test, trace_test, webgl_conformance_d3d11_passthrough_tests, webgl_conformance_d3d9_tests, webgl_conformance_gl_tests, webgl_conformance_tests
is failing since Friday evening.

A common denominator seems to be a v8 roll plus https://codereview.chromium.org/2831733003

first failures:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Debug%20%28NVIDIA%29/builds/948
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28AMD%29/builds/1737
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28NVIDIA%29/builds/20517
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Debug%20%28NVIDIA%29/builds/7408
 

Comment 1 by kbr@chromium.org, Apr 24 2017

Blocking: 699566
Owner: kbr@chromium.org
Status: Started (was: Untriaged)
I think it was my change https://codereview.chromium.org/2831733003 . The key assertion failure seems to be:

[3488:928:0421/205118.589:FATAL:gles2_implementation_impl_autogen.h(606)] Check failed: textures[i] != 0. 
Backtrace:
	base::debug::StackTrace::StackTrace [0x0000000000621FE5+69]
	base::debug::StackTrace::StackTrace [0x0000000000621B08+24]
	logging::LogMessage::~LogMessage [0x00000000006932B0+112]
	gpu::gles2::GLES2Implementation::DeleteTextures [0x00000000194867AB+763]
	blink::DrawingBuffer::ColorBuffer::~ColorBuffer [0x000000001D38C418+712]
	blink::DrawingBuffer::ColorBuffer::`scalar deleting destructor' [0x000000001D38D377+23]
	WTF::RefCounted<blink::DrawingBuffer::ColorBuffer>::Deref [0x000000001D391526+70]
	WTF::DerefIfNotNull<blink::DrawingBuffer::ColorBuffer> [0x000000001D3894BB+27]
	 

Comment 2 by kbr@chromium.org, Apr 24 2017

Cc: pkalinnikov@chromium.org
Components: Blink>WebGL
Summary: Wrong guard in DCHECK code causes assertion failures only on Debug bots and not trybots (was: many failures on gpu fyi windows debug bots)
It was in fact https://codereview.chromium.org/2831733003 , which was reverted in https://codereview.chromium.org/2841573002/ .

The reason that this wasn't caught by the tryservers is that the guard for GPU_CLIENT_DCHECK_CODE_BLOCK is wrong -- rather than checking

  #if !defined(NDEBUG) ...

it should be checking

  #if DCHECK_IS_ON() ...

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88c1201998461775ec1c604baa77c25c8023af8c

commit 88c1201998461775ec1c604baa77c25c8023af8c
Author: kbr <kbr@chromium.org>
Date: Mon Apr 24 22:12:54 2017

Make GPU_CLIENT_DCHECK_CODE_BLOCK obey DCHECK_ALWAYS_ON.

Note that this block of #ifdefs violates the indentation guidelines,
but I'm ignoring that because the current form is more readable.

BUG= 714761 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2837773004
Cr-Commit-Position: refs/heads/master@{#466790}

[modify] https://crrev.com/88c1201998461775ec1c604baa77c25c8023af8c/gpu/command_buffer/client/gles2_implementation.h

Comment 5 by kbr@chromium.org, Apr 25 2017

Status: Verified (was: Started)
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/437659 verifies that this assertion is now caught on the trybots, which run with dcheck_always_on=true .

Comment 6 by kbr@chromium.org, Apr 25 2017

Cc: msrchandra@chromium.org
 Issue 714423  has been merged into this issue.
Project Member

Comment 7 by ClusterFuzz, Apr 25 2017

Labels: OS-Linux

Sign in to add a comment