Wrong guard in DCHECK code causes assertion failures only on Debug bots and not trybots |
|||||
Issue descriptionThe product of Win10 Debug (NVIDIA), Win7 Debug (AMD), Win7 Debug (NVIDIA), Win7 x64 Debug (NVIDIA) and context_lost_tests, depth_capture_tests, pixel_test, trace_test, webgl_conformance_d3d11_passthrough_tests, webgl_conformance_d3d9_tests, webgl_conformance_gl_tests, webgl_conformance_tests is failing since Friday evening. A common denominator seems to be a v8 roll plus https://codereview.chromium.org/2831733003 first failures: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Debug%20%28NVIDIA%29/builds/948 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28AMD%29/builds/1737 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28NVIDIA%29/builds/20517 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Debug%20%28NVIDIA%29/builds/7408
,
Apr 24 2017
It was in fact https://codereview.chromium.org/2831733003 , which was reverted in https://codereview.chromium.org/2841573002/ . The reason that this wasn't caught by the tryservers is that the guard for GPU_CLIENT_DCHECK_CODE_BLOCK is wrong -- rather than checking #if !defined(NDEBUG) ... it should be checking #if DCHECK_IS_ON() ...
,
Apr 24 2017
Also, this happened at least on macOS too; compare: https://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug%20%28AMD%29/builds/4067 to https://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug%20%28AMD%29/builds/4068
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88c1201998461775ec1c604baa77c25c8023af8c commit 88c1201998461775ec1c604baa77c25c8023af8c Author: kbr <kbr@chromium.org> Date: Mon Apr 24 22:12:54 2017 Make GPU_CLIENT_DCHECK_CODE_BLOCK obey DCHECK_ALWAYS_ON. Note that this block of #ifdefs violates the indentation guidelines, but I'm ignoring that because the current form is more readable. BUG= 714761 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2837773004 Cr-Commit-Position: refs/heads/master@{#466790} [modify] https://crrev.com/88c1201998461775ec1c604baa77c25c8023af8c/gpu/command_buffer/client/gles2_implementation.h
,
Apr 25 2017
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/437659 verifies that this assertion is now caught on the trybots, which run with dcheck_always_on=true .
,
Apr 25 2017
,
Apr 25 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kbr@chromium.org
, Apr 24 2017Owner: kbr@chromium.org
Status: Started (was: Untriaged)