New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714759 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Add about:flag for offline previews

Project Member Reported by ryansturm@chromium.org, Apr 24 2017

Issue description

Currently, finch is the only mechanism controlling offline previews, but about:flags should expose a way to turn on offline previews for every navigation, slow connection navigations, and disabled in additional to the default value.

 

Comment 1 by bengr@chromium.org, Apr 30 2017

Cc: megjab...@chromium.org
Ideally this would use the same flags megjablon already set up for other previews.
Status: Started (was: Assigned)
I am using an enabled/disable type flag. tbansal@ is adding a NQE dropdown flag in about:flags. The user would enable offline previews with default field trial values and only get offline previews on 2G or worse. To simulate slow networks they should use the NQE flag.
Project Member

Comment 3 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28839dee4819459127f8036e99f32d917601ee50

commit 28839dee4819459127f8036e99f32d917601ee50
Author: ryansturm <ryansturm@chromium.org>
Date: Fri May 05 17:34:27 2017

Adding and Android about:flags feature for offline previews

This adds a command line and about:flags feature for offline previews on
Android.

BUG= 714759 

Review-Url: https://codereview.chromium.org/2854893003
Cr-Commit-Position: refs/heads/master@{#469702}

[modify] https://crrev.com/28839dee4819459127f8036e99f32d917601ee50/chrome/browser/about_flags.cc
[modify] https://crrev.com/28839dee4819459127f8036e99f32d917601ee50/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/28839dee4819459127f8036e99f32d917601ee50/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/28839dee4819459127f8036e99f32d917601ee50/components/previews/core/BUILD.gn
[modify] https://crrev.com/28839dee4819459127f8036e99f32d917601ee50/components/previews/core/previews_experiments.cc
[modify] https://crrev.com/28839dee4819459127f8036e99f32d917601ee50/components/previews/core/previews_experiments.h
[modify] https://crrev.com/28839dee4819459127f8036e99f32d917601ee50/components/previews/core/previews_experiments_unittest.cc
[add] https://crrev.com/28839dee4819459127f8036e99f32d917601ee50/components/previews/core/previews_features.cc
[add] https://crrev.com/28839dee4819459127f8036e99f32d917601ee50/components/previews/core/previews_features.h
[modify] https://crrev.com/28839dee4819459127f8036e99f32d917601ee50/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Comment 5 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 6 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Sign in to add a comment