New issue
Advanced search Search tips

Issue 714738 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 714735



Sign in to add a comment

Add disclosures for unbound webapk

Project Member Reported by yfried...@chromium.org, Apr 24 2017

Issue description

If we can have an "Unbound Webapk" it may not be clear which browser the webapk is using as its host. We should add relevant UIs (first-run, notification, etc) that browser's data (e.g. cookies) is being used
 
Owner: yfried...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88c8153ffb73869b07a17c3d804630e401c730fd

commit 88c8153ffb73869b07a17c3d804630e401c730fd
Author: yfriedman <yfriedman@chromium.org>
Date: Mon May 29 14:53:41 2017

Implement privacy disclosure for an unbound webapk.

Some WebApks can be run with different browser hosts. This CL adds a
notification that the WebApk is using Chrome as a host and may share
browsing data with the app.

BUG= 714738 

Review-Url: https://codereview.chromium.org/2841193002
Cr-Commit-Position: refs/heads/master@{#475350}

[modify] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
[modify] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java
[modify] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
[modify] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
[modify] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
[modify] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java
[modify] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
[add] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkDisclosureNotificationManager.java
[add] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkDisclosureNotificationService.java
[modify] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java
[modify] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/java_sources.gni
[modify] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationBuilderBaseTest.java
[modify] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java
[modify] https://crrev.com/88c8153ffb73869b07a17c3d804630e401c730fd/tools/metrics/histograms/enums.xml

Cc: yfried...@chromium.org
Owner: sbirch@chromium.org
preliminary implementation is in - Sam can you run this through UI
Owner: yfried...@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment