New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714717 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Identify destination devices by name (rather than “TV”)

Project Member Reported by bettes@chromium.org, Apr 24 2017

Issue description

Today's string: "Now casting to your TV" 
Expected string: "Now casting to <device name>"

UX review deck:
https://docs.google.com/presentation/d/1AJZrLD8g88kUHIyMy_G80yd77MSyriNB6aMcfPTc0dg/edit#slide=id.g1d5c34d4a2_4_10


 
Screen Shot 2017-04-24 at 11.30.35 AM.png
22.5 KB View Download

Comment 1 by sko...@chromium.org, Apr 24 2017

Labels: -Type-Bug Hotlist-Fixit-PE2017 Type-Feature
Status: Available (was: Untriaged)

Comment 2 by mfo...@chromium.org, May 10 2017

Labels: Hotlist-Polish

Comment 3 by x...@chromium.org, Jul 17 2017

Owner: x...@chromium.org
Status: Assigned (was: Available)

Comment 4 by x...@chromium.org, Jul 19 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba8724f480e006fe71b3f856edf172ae68ab7245

commit ba8724f480e006fe71b3f856edf172ae68ab7245
Author: Xiangjun Zhang <xjz@chromium.org>
Date: Thu Aug 03 06:43:25 2017

Show remote device name in media remoting UI.

Bug:  714717 
Change-Id: If707c50a569b1c9ebbed6568c2a6631e55bc1e95
Reviewed-on: https://chromium-review.googlesource.com/584632
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Anton Vayvod <avayvod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491663}
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/content/app/strings/content_strings.grd
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/content/child/blink_platform_impl.cc
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/content/renderer/media/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/media/base/media_observer.h
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/media/remoting/renderer_controller.cc
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/media/remoting/renderer_controller_unittest.cc
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/media/remoting/shared_session.h
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/third_party/WebKit/Source/core/html/HTMLAudioElement.h
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/third_party/WebKit/Source/core/html/HTMLVideoElement.h
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/third_party/WebKit/Source/core/html/media/MediaRemotingElements.cpp
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/third_party/WebKit/Source/core/html/media/MediaRemotingInterstitial.cpp
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/third_party/WebKit/Source/core/html/media/MediaRemotingInterstitial.h
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/third_party/WebKit/public/platform/WebLocalizedString.h
[modify] https://crrev.com/ba8724f480e006fe71b3f856edf172ae68ab7245/third_party/WebKit/public/platform/WebMediaPlayerClient.h

Comment 6 by x...@chromium.org, Aug 3 2017

Status: Fixed (was: Started)

Comment 7 by mfo...@chromium.org, Mar 31 2018

Labels: -Hotlist-Fixit-PE2017

Sign in to add a comment