Issue metadata
Sign in to add a comment
|
25.2% regression in media.tough_video_cases at 466459:466532 |
||||||||||||||||||||||
Issue descriptionRegressed metric: vm_working_set_delta_size
,
Apr 24 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8981409334703464320
,
Apr 25 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : jkummerow Commit : 75ce09b53392eee23f3c0c6727463f9d9ef9c73f Date : Fri Apr 21 17:31:29 2017 Subject: Fix HashTable growth strategy to be 2x instead of 4x Bisect Details Configuration: winx64intel_perf_bisect Benchmark : media.tough_video_cases Metric : vm_working_set_delta_size/tulip2.m4a_renderer Change : 19.80% | 2662.66666667 -> 3190.0 Revision Result N chromium@466458 2662.67 +- 270.919 6 good chromium@466495 2569.33 +- 212.991 6 good chromium@466505 2726.0 +- 218.266 6 good chromium@466510 2735.56 +- 454.856 9 good chromium@466512 2654.67 +- 321.032 6 good chromium@466513 2646.0 +- 334.221 6 good chromium@466513,v8@75ce09b533 3096.67 +- 464.635 6 bad <-- chromium@466513,v8@dddfcfd0a9 3150.0 +- 376.202 6 bad chromium@466514 3021.33 +- 269.676 6 bad chromium@466532 3190.0 +- 115.897 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests media.tough_video_cases Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8981409334703464320 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5323191364354048 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 25 2017
jkummerow@ can you imagine how this could cause a memory regression?
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de10164f6758e68bf4628cbd63c5cbe53ce644ed commit de10164f6758e68bf4628cbd63c5cbe53ce644ed Author: Filip Gorski <fgorski@google.com> Date: Fri Oct 05 21:26:40 2018 [Zine] Favicon server switch cleanup * Enabling the feature by default * Removing old experiment groups. Bug: 714709 Change-Id: I7962bcba392d67402a58f89510298be034b47d11 Reviewed-on: https://chromium-review.googlesource.com/c/1259606 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#597307} [modify] https://crrev.com/de10164f6758e68bf4628cbd63c5cbe53ce644ed/components/ntp_snippets/features.cc [modify] https://crrev.com/de10164f6758e68bf4628cbd63c5cbe53ce644ed/testing/variations/fieldtrial_testing_config.json |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by w...@chromium.org
, Apr 24 2017