New issue
Advanced search Search tips

Issue 714697 link

Starred by 1 user
Status: Verified
Owner:
x...@chromium.org
Closed: May 2017
Cc:
shibasheikh@chromium.org
weifangsun@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

CUPS Printer Settings: Add a Printer link should be implemented as a button

Project Member Reported by weifangsun@chromium.org, Apr 24 2017 
Currently, the "Add a printer" action is a link at the top of the printer list page. Per UI review, this should be a button.

Comment 1 by weifangsun@chromium.org, Apr 26 2017

Cc: weifangsun@chromium.org
Owner: shibasheikh@chromium.org
FYI - Shiba is working on a mock for this.

Comment 2 by shibasheikh@chromium.org, Apr 28 2017 

Attached screenshot of mock for button placement

Flat button spec:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_buttons.png%3Fz=half
Screen Shot 2017-04-27 at 9.54.29 PM.png
890 KB View Download

Comment 3 by weifangsun@chromium.org, Apr 28 2017

Cc: -x...@chromium.org shibasheikh@chromium.org
Owner: x...@chromium.org

Comment 4 by x...@chromium.org, May 5 2017

Status: Started (was: Assigned)

Comment 5 by x...@chromium.org, May 5 2017 

https://codereview.chromium.org/2867563002/ 
See the screenshot.
Screenshot 2017-05-05 at 14.58.48.png
165 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, May 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4b69e228383bae8fb9c44ce9b11e7800766ed55

commit a4b69e228383bae8fb9c44ce9b11e7800766ed55
Author: xdai <xdai@chromium.org>
Date: Mon May 08 20:22:38 2017

[CUPS] Modify the "Add Printer" link to a button.

BUG= 714697 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2867563002
Cr-Commit-Position: refs/heads/master@{#470103}

[modify] https://crrev.com/a4b69e228383bae8fb9c44ce9b11e7800766ed55/chrome/browser/resources/settings/printing_page/cups_printers.html

Comment 7 by x...@chromium.org, May 8 2017

Status: Fixed (was: Started)

Comment 8 by helenzhang@google.com, May 22 2017

Status: Verified (was: Fixed)
Verified in Chrome OS 60.0.3105.0, 9574.0.0.
►

Sign in to add a comment