New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 714689 link

Starred by 1 user
Status: Archived
Owner:
jamescook@chromium.org
Closed: Apr 2017
Cc:
xiy...@chromium.org
█ yzshen@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add mojo EqualsTraits<> for ImageSkia for sending UserSessions

Project Member Reported by jamescook@chromium.org, Apr 24 2017 
On Chrome OS for mustash we want to avoid sending duplicate avatar images from browser to ash. To do this we need to be able to compare two ash::mojom::UserSession objects. This requires comparing two gfx.mojom.ImageSkia objects. There's no equals function for this right now. It would probably be OK to use ImageSkia::BackedBySameObjectAs() for comparison.

See ui/gfx/image/mojo/image.mojom

Comment 1 by jamescook@chromium.org, Apr 25 2017

Cc: yzshen@chromium.org
Components: Internals>Mojo>Bindings
Status: Started (was: Assigned)
Summary: Add mojo EqualsTraits<> for ImageSkia for sending UserSessions (was: Add mojo structtraits for ImageSkia Equals())
This requires moving EqualsTraits<> out of mojo::internals. Then SessionControllerClient can can provide a custom comparison for ImageSkia, which allows us to avoid adding a generic Equals() to ImageSkia.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9404e80f80b4bddfa2c24ca042393ceb5a5b882

commit b9404e80f80b4bddfa2c24ca042393ceb5a5b882
Author: jamescook <jamescook@chromium.org>
Date: Tue Apr 25 23:24:21 2017

mojo: Make EqualsTraits<> part of public C++ API

Users of mapped types sometimes need to provide their own custom
comparsion functions for classes that do not provide operator==() or an
Equals() method. Move EqualsTraits<> out of mojo internals, similar to
how CloneTraits<> is handled.

BUG= 714689 
TEST=compiles

Review-Url: https://codereview.chromium.org/2837353002
Cr-Commit-Position: refs/heads/master@{#467160}

[modify] https://crrev.com/b9404e80f80b4bddfa2c24ca042393ceb5a5b882/mojo/public/cpp/bindings/BUILD.gn
[rename] https://crrev.com/b9404e80f80b4bddfa2c24ca042393ceb5a5b882/mojo/public/cpp/bindings/equals_traits.h
[modify] https://crrev.com/b9404e80f80b4bddfa2c24ca042393ceb5a5b882/mojo/public/cpp/bindings/lib/wtf_clone_equals_util.h
[modify] https://crrev.com/b9404e80f80b4bddfa2c24ca042393ceb5a5b882/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl
[modify] https://crrev.com/b9404e80f80b4bddfa2c24ca042393ceb5a5b882/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_template_definition.tmpl
[modify] https://crrev.com/b9404e80f80b4bddfa2c24ca042393ceb5a5b882/mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_template_definition.tmpl
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/714f3da6005d557c7dff987fb3ee097201cb31fd

commit 714f3da6005d557c7dff987fb3ee097201cb31fd
Author: jamescook <jamescook@chromium.org>
Date: Wed Apr 26 00:11:17 2017

cros: Don't send duplicate UserSession mojo messages to ash

After the profile is loaded the SessionControllerClient in the browser
sends an updated ash::mojom::UserSession to ash. Most of the time the
message is the same as the one just sent when the session was started.

BUG= 714689 , 712799 
TEST=added to SessionControllerClientTest in unit_tests

Review-Url: https://codereview.chromium.org/2842693002
Cr-Commit-Position: refs/heads/master@{#467172}

[modify] https://crrev.com/714f3da6005d557c7dff987fb3ee097201cb31fd/chrome/browser/ui/ash/session_controller_client.cc
[modify] https://crrev.com/714f3da6005d557c7dff987fb3ee097201cb31fd/chrome/browser/ui/ash/session_controller_client.h
[modify] https://crrev.com/714f3da6005d557c7dff987fb3ee097201cb31fd/chrome/browser/ui/ash/session_controller_client_unittest.cc

Comment 4 by jamescook@chromium.org, Apr 26 2017

Status: Fixed (was: Started)

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment