StaleHostResolver lifetime issues |
||||
Issue description(moving here from internal bug b/29525886) UMA for "DNS.StaleHostResolver.RequestOutcome" isn't getting reported as often as it should be. One case where this would happen is when stale data is returned and the network request never finishes, so as a quick partial fix, I can change StaleHostResolver to report this histogram as soon as its value is known instead of waiting until the network returns. But that doesn't explain all of the missing data. I also found that the histogram reporting code isn't always getting called when it should be in the existing unit tests, and I suspect there's a lifetime issue that's going to need more attention.
,
Apr 5 2018
Note that when running the StaleUsability unit-tests we see internal RequestImpl structures leak, seemingly due to network resolve requests not completing, though it's unclear whether they are being dropped during unit-test teardown, or would never completed (see issue 829097 ).
,
Apr 5 2018
,
Apr 5 2018
I'll try to look into StaleHostResolver issues.
,
Dec 21
Looks reasonably well matched now: DNS.StaleHostResolver.RequestOutcome: Returned network result; stale cached result was available. 1,274,715,005 Returned network result; no stale cached result was available. 218,565,130 adds up to DNS.StaleHostResolver.NetworkEarly When a DNS request made through StaleHostResolver returns, a stale cached result was available, and the network responded before or exactly at the stale delay, how much earlier it responded. Aggregate number of samples: 1,286,057,032 DNS.StaleHostResolver.NetworkLate When a DNS request made through StaleHostResolver returns, a stale cached result was available, and the network responded after the stale delay, how much later it responded. Aggregate number of samples: 198,603,697 |
||||
►
Sign in to add a comment |
||||
Comment 1 by mge...@chromium.org
, Mar 23 2018Status: Available (was: Assigned)