New issue
Advanced search Search tips

Issue 714677 link

Starred by 0 users
Status: Archived
Owner:
xiy...@chromium.org
Closed: Jun 2017
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 679450



Sign in to add a comment

mash: Lock screen needs to make active window exit fullscreen

Project Member Reported by xiy...@chromium.org, Apr 24 2017 
In cash, this is done by manipulating active window state directly [1].

We need to figure out a way for mash.

[1]: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/lock/screen_locker.cc?rcl=27028d78159cff5447dd3f98c5da756c91c65658&l=476-485
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74ada5299187532cfbb72c0641272fa7dbaa31ae

commit 74ada5299187532cfbb72c0641272fa7dbaa31ae
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Thu Jun 29 23:22:43 2017

mash: Exit fullscreen active window on lock

- Move the fullscreen exit logic to ash where active window
  state can be obtained and manipulated.
- Work around the Shell::GetAshConfig CHECK when LockWindow
  is created in browser process for webui based lock screen;

BUG= 714677 
TEST=Existing ScreenLockerTest.TestFullscreenExit

Change-Id: I53782d617bf5b30d30139bb7fa38a6e2a6fdedf2
Reviewed-on: https://chromium-review.googlesource.com/556461
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483542}
[modify] https://crrev.com/74ada5299187532cfbb72c0641272fa7dbaa31ae/ash/login/ui/lock_screen.cc
[modify] https://crrev.com/74ada5299187532cfbb72c0641272fa7dbaa31ae/ash/login/ui/lock_window.cc
[modify] https://crrev.com/74ada5299187532cfbb72c0641272fa7dbaa31ae/ash/login/ui/lock_window.h
[modify] https://crrev.com/74ada5299187532cfbb72c0641272fa7dbaa31ae/ash/public/interfaces/session_controller.mojom
[modify] https://crrev.com/74ada5299187532cfbb72c0641272fa7dbaa31ae/ash/session/session_controller.cc
[modify] https://crrev.com/74ada5299187532cfbb72c0641272fa7dbaa31ae/ash/session/session_controller.h
[modify] https://crrev.com/74ada5299187532cfbb72c0641272fa7dbaa31ae/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/74ada5299187532cfbb72c0641272fa7dbaa31ae/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/74ada5299187532cfbb72c0641272fa7dbaa31ae/chrome/browser/ui/ash/session_controller_client.cc
[modify] https://crrev.com/74ada5299187532cfbb72c0641272fa7dbaa31ae/chrome/browser/ui/ash/session_controller_client.h
[modify] https://crrev.com/74ada5299187532cfbb72c0641272fa7dbaa31ae/chrome/browser/ui/ash/session_controller_client_unittest.cc

Comment 2 by xiy...@chromium.org, Jun 30 2017

Status: Fixed (was: Available)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService
►

Sign in to add a comment