Chromium currently has at least 3 autoplay policies (arguable 4 or 5 if we count the sub-types). There is a new one coming so we should merge the autoplay logic into policies to avoid spaghetti code.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f264da2cfe8d40c211f07ce3960898e5c998773 commit 1f264da2cfe8d40c211f07ce3960898e5c998773 Author: mlamouri <mlamouri@chromium.org> Date: Tue Apr 25 22:34:42 2017 Create autoplay policy flag and merge cross-origin autoplay blocking into it. Also allows to use this flag to turn off autoplay restrictions on Android. Follow-ups will merge kDisableGestureRequirementsForMediaPlayback into this new flag. BUG= 714676 Review-Url: https://codereview.chromium.org/2837023002 Cr-Commit-Position: refs/heads/master@{#467142} [modify] https://crrev.com/1f264da2cfe8d40c211f07ce3960898e5c998773/chrome/browser/about_flags.cc [modify] https://crrev.com/1f264da2cfe8d40c211f07ce3960898e5c998773/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/1f264da2cfe8d40c211f07ce3960898e5c998773/chrome/browser/flag_descriptions.h [modify] https://crrev.com/1f264da2cfe8d40c211f07ce3960898e5c998773/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/1f264da2cfe8d40c211f07ce3960898e5c998773/content/browser/renderer_host/render_view_host_impl.cc [modify] https://crrev.com/1f264da2cfe8d40c211f07ce3960898e5c998773/content/child/runtime_features.cc [modify] https://crrev.com/1f264da2cfe8d40c211f07ce3960898e5c998773/content/public/common/content_features.cc [modify] https://crrev.com/1f264da2cfe8d40c211f07ce3960898e5c998773/content/public/common/content_features.h [modify] https://crrev.com/1f264da2cfe8d40c211f07ce3960898e5c998773/media/base/media_switches.cc [modify] https://crrev.com/1f264da2cfe8d40c211f07ce3960898e5c998773/media/base/media_switches.h [modify] https://crrev.com/1f264da2cfe8d40c211f07ce3960898e5c998773/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6 commit d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6 Author: mlamouri <mlamouri@chromium.org> Date: Thu Apr 27 15:49:42 2017 Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. The flag should only be set by tests and will allow all autoplay related restrictions such as autoplay policy and background playback to be disabled. BUG= 714676 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2843913003 Cr-Commit-Position: refs/heads/master@{#467692} [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/chrome/android/BUILD.gn [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/chrome/android/javatests/src/org/chromium/chrome/browser/VideoFullscreenOrientationLockChromeTest.java [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PauseOnHeadsetUnplugTest.java [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/chrome/browser/about_flags.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/chrome/browser/android/voice_search_tab_helper.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/chrome/browser/flag_descriptions.h [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/chrome/browser/media/defer_background_media_browsertest.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/chrome/browser/media/encrypted_media_browsertest.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/chromecast/browser/cast_browser_main_parts.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/browser/media/encrypted_media_browsertest.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/browser/media/media_browsertest.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/browser/media/media_source_browsertest.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/browser/media/session/media_session_impl_visibility_browsertest.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/browser/renderer_host/render_process_host_browsertest.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/browser/renderer_host/render_view_host_impl.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/browser/webrtc/webrtc_capture_from_element_browsertest.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/public/android/java/src/org/chromium/content/common/ContentSwitches.java [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/public/android/javatests/src/org/chromium/content/browser/VideoFullscreenOrientationLockTest.java [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/public/common/content_switches.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/public/common/content_switches.h [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/shell/app/shell_main_delegate.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/media/base/android/BUILD.gn [add] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/media/base/android/java/src/org/chromium/media/MediaSwitches.java [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/media/base/media_switches.cc [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/media/base/media_switches.h [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/tools/perf/benchmarks/blink_perf.py [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/tools/perf/benchmarks/media.py [modify] https://crrev.com/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6/tools/perf/measurements/media.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54e35df000303d1a3b5214db2232aa2fb5c12e3a commit 54e35df000303d1a3b5214db2232aa2fb5c12e3a Author: timvolodine <timvolodine@chromium.org> Date: Thu Apr 27 17:14:21 2017 Revert of Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. (patchset #2 id:20001 of https://codereview.chromium.org/2843913003/ ) Reason for revert: broke clang-clankium-tot-builder crbug.com/716075 (FullscreenWebContentsActivityTest not updated) Original issue's description: > Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. > > The flag should only be set by tests and will allow all autoplay related > restrictions such as autoplay policy and background playback to be > disabled. > > BUG= 714676 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2843913003 > Cr-Commit-Position: refs/heads/master@{#467692} > Committed: https://chromium.googlesource.com/chromium/src/+/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6 TBR=dalecurtis@chromium.org,jam@chromium.org,mlamouri@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 714676 Review-Url: https://codereview.chromium.org/2851453003 Cr-Commit-Position: refs/heads/master@{#467715} [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/chrome/android/BUILD.gn [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/chrome/android/javatests/src/org/chromium/chrome/browser/VideoFullscreenOrientationLockChromeTest.java [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PauseOnHeadsetUnplugTest.java [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/chrome/browser/about_flags.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/chrome/browser/android/voice_search_tab_helper.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/chrome/browser/flag_descriptions.h [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/chrome/browser/media/defer_background_media_browsertest.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/chrome/browser/media/encrypted_media_browsertest.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/chromecast/browser/cast_browser_main_parts.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/browser/media/encrypted_media_browsertest.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/browser/media/media_browsertest.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/browser/media/media_source_browsertest.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/browser/media/session/media_session_impl_visibility_browsertest.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/browser/renderer_host/render_process_host_browsertest.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/browser/renderer_host/render_view_host_impl.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/browser/webrtc/webrtc_capture_from_element_browsertest.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/public/android/java/src/org/chromium/content/common/ContentSwitches.java [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/public/android/javatests/src/org/chromium/content/browser/VideoFullscreenOrientationLockTest.java [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/public/common/content_switches.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/public/common/content_switches.h [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/shell/app/shell_main_delegate.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/media/base/android/BUILD.gn [delete] https://crrev.com/bd3a5c1291959abcb9b70381e63156d6ae234e5a/media/base/android/java/src/org/chromium/media/MediaSwitches.java [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/media/base/media_switches.cc [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/media/base/media_switches.h [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/tools/perf/benchmarks/blink_perf.py [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/tools/perf/benchmarks/media.py [modify] https://crrev.com/54e35df000303d1a3b5214db2232aa2fb5c12e3a/tools/perf/measurements/media.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32d29a10153865441252e100a9781648b8df795b commit 32d29a10153865441252e100a9781648b8df795b Author: zmin <zmin@chromium.org> Date: Thu Apr 27 20:48:26 2017 Reland of name kDisableGestureRequirementForMediaPlayback and make it a test-only flag. (patchset #1 id:1 of https://codereview.chromium.org/2851453003/ ) Reason for revert: Reland the original patch as timvolodine and I believe it's not related to the compile failure early today. Original issue's description: > Revert of Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. (patchset #2 id:20001 of https://codereview.chromium.org/2843913003/ ) > > Reason for revert: > broke clang-clankium-tot-builder crbug.com/716075 > > (FullscreenWebContentsActivityTest not updated) > > Original issue's description: > > Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. > > > > The flag should only be set by tests and will allow all autoplay related > > restrictions such as autoplay policy and background playback to be > > disabled. > > > > BUG= 714676 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > > > Review-Url: https://codereview.chromium.org/2843913003 > > Cr-Commit-Position: refs/heads/master@{#467692} > > Committed: https://chromium.googlesource.com/chromium/src/+/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6 > > TBR=dalecurtis@chromium.org,jam@chromium.org,mlamouri@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 714676 > > Review-Url: https://codereview.chromium.org/2851453003 > Cr-Commit-Position: refs/heads/master@{#467715} > Committed: https://chromium.googlesource.com/chromium/src/+/54e35df000303d1a3b5214db2232aa2fb5c12e3a TBR=dalecurtis@chromium.org,jam@chromium.org,mlamouri@chromium.org,timvolodine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 714676 Review-Url: https://codereview.chromium.org/2845973005 Cr-Commit-Position: refs/heads/master@{#467782} [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/chrome/android/BUILD.gn [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/chrome/android/javatests/src/org/chromium/chrome/browser/VideoFullscreenOrientationLockChromeTest.java [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PauseOnHeadsetUnplugTest.java [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/chrome/browser/about_flags.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/chrome/browser/android/voice_search_tab_helper.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/chrome/browser/flag_descriptions.h [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/chrome/browser/media/defer_background_media_browsertest.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/chrome/browser/media/encrypted_media_browsertest.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/chromecast/browser/cast_browser_main_parts.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/browser/media/encrypted_media_browsertest.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/browser/media/media_browsertest.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/browser/media/media_source_browsertest.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/browser/media/session/media_session_impl_visibility_browsertest.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/browser/renderer_host/render_process_host_browsertest.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/browser/renderer_host/render_view_host_impl.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/browser/webrtc/webrtc_capture_from_element_browsertest.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/public/android/java/src/org/chromium/content/common/ContentSwitches.java [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/public/android/javatests/src/org/chromium/content/browser/VideoFullscreenOrientationLockTest.java [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/public/common/content_switches.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/public/common/content_switches.h [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/shell/app/shell_main_delegate.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/media/base/android/BUILD.gn [add] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/media/base/android/java/src/org/chromium/media/MediaSwitches.java [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/media/base/media_switches.cc [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/media/base/media_switches.h [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/tools/perf/benchmarks/blink_perf.py [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/tools/perf/benchmarks/media.py [modify] https://crrev.com/32d29a10153865441252e100a9781648b8df795b/tools/perf/measurements/media.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55a0543c377a69bbb9ab8c49629f037219289cd0 commit 55a0543c377a69bbb9ab8c49629f037219289cd0 Author: mlamouri <mlamouri@chromium.org> Date: Thu May 11 10:34:07 2017 Make autoplay policies no longer platform dependant. This is moving the two web preferences to be available on both platforms and adds a central point to check for the current autoplay policy. Next step will be to merge the two Blink Settings into one. BUG= 714676 Review-Url: https://codereview.chromium.org/2846623003 Cr-Commit-Position: refs/heads/master@{#470904} [modify] https://crrev.com/55a0543c377a69bbb9ab8c49629f037219289cd0/android_webview/browser/aw_settings.cc [modify] https://crrev.com/55a0543c377a69bbb9ab8c49629f037219289cd0/chrome/browser/about_flags.cc [modify] https://crrev.com/55a0543c377a69bbb9ab8c49629f037219289cd0/chrome/browser/android/voice_search_tab_helper.cc [modify] https://crrev.com/55a0543c377a69bbb9ab8c49629f037219289cd0/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/55a0543c377a69bbb9ab8c49629f037219289cd0/chrome/browser/flag_descriptions.h [modify] https://crrev.com/55a0543c377a69bbb9ab8c49629f037219289cd0/content/browser/renderer_host/render_view_host_impl.cc [modify] https://crrev.com/55a0543c377a69bbb9ab8c49629f037219289cd0/content/child/runtime_features.cc [modify] https://crrev.com/55a0543c377a69bbb9ab8c49629f037219289cd0/content/public/common/common_param_traits_macros.h [modify] https://crrev.com/55a0543c377a69bbb9ab8c49629f037219289cd0/content/public/common/web_preferences.cc [modify] https://crrev.com/55a0543c377a69bbb9ab8c49629f037219289cd0/content/public/common/web_preferences.h [modify] https://crrev.com/55a0543c377a69bbb9ab8c49629f037219289cd0/content/renderer/render_view_impl.cc [modify] https://crrev.com/55a0543c377a69bbb9ab8c49629f037219289cd0/media/base/media_switches.cc [modify] https://crrev.com/55a0543c377a69bbb9ab8c49629f037219289cd0/media/base/media_switches.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c commit 276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c Author: mlamouri <mlamouri@chromium.org> Date: Fri May 12 09:24:28 2017 Autoplay: use an autoplay policy setting in Blink. This is a continuity of the autoplay policy that was introduced in the embedder. BUG= 714676 R=dalecurtis@chromium.org,dcheng@chromium.org,nasko@chromium.org Review-Url: https://codereview.chromium.org/2850553002 Cr-Commit-Position: refs/heads/master@{#471256} [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/content/renderer/render_view_impl.cc [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/http/tests/media/resources/autoplay-crossorigin-iframe.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/http/tests/webaudio/resources/autoplay-crossorigin-iframe.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/autoplay-document-move.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/autoplay-from-mediastream-to-src.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/autoplay-muted-conditions.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/autoplay-muted-datasaver-off.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/autoplay-muted-datasaver-on.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/autoplay-muted.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/autoplay-never-visible.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/autoplay-non-whitelisted-scope.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/autoplay-unmute-offscreen.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/autoplay-when-visible-multiple-times.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/autoplay-when-visible.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/autoplay-whitelisted-scope.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/media-play-promise.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/play-promise-crash.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/LayoutTests/media/video-play-require-user-gesture.html [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/Source/core/frame/Settings.h [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/Source/core/frame/Settings.json5 [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/Source/core/html/media/AutoplayPolicy.h [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/Source/core/testing/InternalSettings.cpp [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/Source/core/testing/InternalSettings.h [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/Source/core/testing/InternalSettings.idl [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/Source/web/AssertMatchingEnums.cpp [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/Source/web/WebSettingsImpl.cpp [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/Source/web/WebSettingsImpl.h [modify] https://crrev.com/276a6f39aefbc4f23fe98fb71ca4881a0a0ff29c/third_party/WebKit/public/web/WebSettings.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8 commit 163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Mon Dec 11 17:34:17 2017 Remove flag to by-pass autoplay restrictions for tests. Bug: 714676 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I80fc5393b8967d15fb3ff44cea51b5c3a9e85f4b Reviewed-on: https://chromium-review.googlesource.com/816855 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#523124} [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/chrome/android/javatests/src/org/chromium/chrome/browser/FullscreenActivityTest.java [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/chrome/android/javatests/src/org/chromium/chrome/browser/VideoFullscreenOrientationLockChromeTest.java [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PauseOnHeadsetUnplugTest.java [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PictureInPictureControllerTest.java [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/chrome/android/javatests/src/org/chromium/chrome/browser/video/FullscreenVideoTest.java [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/chrome/browser/media/encrypted_media_browsertest.cc [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/chromecast/browser/cast_browser_main_parts.cc [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/content/browser/media/encrypted_media_browsertest.cc [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/content/browser/media/media_browsertest.cc [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/content/browser/media/media_source_browsertest.cc [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/content/browser/media/session/media_session_browsertest.cc [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/content/browser/media/session/media_session_impl_visibility_browsertest.cc [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/content/browser/renderer_host/render_process_host_browsertest.cc [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/content/browser/webrtc/webrtc_capture_from_element_browsertest.cc [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/content/public/android/javatests/src/org/chromium/content/browser/VideoFullscreenOrientationLockTest.java [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/content/public/android/javatests/src/org/chromium/content/browser/VideoRotateToFullscreenTest.java [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/content/shell/app/shell_main_delegate.cc [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/media/base/android/java/src/org/chromium/media/MediaSwitches.java [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/media/base/media_switches.cc [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/media/base/media_switches.h [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/tools/perf/benchmarks/blink_perf.py [modify] https://crrev.com/163e1b41d7fa1db6d2fac09e7727f6e3cad5ece8/tools/perf/benchmarks/media.py
Comment 1 by mlamouri@chromium.org
, Apr 25 2017