Enable MacOSX notifications by default |
||||||
Issue descriptionWe originally wanted to do it via finch but merging the flag change is the recommended way and the CL is very small.
,
Apr 24 2017
miguelg@ can you please request for M59 merge(branch:3071) asap so that we can pick the Cl for tomorrow dev and subsequent Beta release.
,
Apr 24 2017
,
Apr 24 2017
Done. I think it should be safe to merge it right now. The feature in question has been enabled in canary/dev for weeks (via finch) this is just turning the flag on now that we have launch approval since that is the recommended procedure for 100% launches (we will have a kill switch via finch just in case)
,
Apr 24 2017
Approving merge to M59 branch 3071 based on comment #4. Please merge ASAP. Thank you.
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ed8de2cf4ca8f1c0597376ad57cf7f3a5616b8d commit 1ed8de2cf4ca8f1c0597376ad57cf7f3a5616b8d Author: Miguel Garcia <miguelg@chromium.org> Date: Mon Apr 24 22:24:43 2017 Enable MacOSX native notifications by default TBR=finnur BUG= 714665 Review-Url: https://codereview.chromium.org/2833993002 Cr-Commit-Position: refs/heads/master@{#466687} (cherry picked from commit 9b50286f24130476571e2d8e2a5a410e20f9f787) Review-Url: https://codereview.chromium.org/2840763002 . Cr-Commit-Position: refs/branch-heads/3071@{#181} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/1ed8de2cf4ca8f1c0597376ad57cf7f3a5616b8d/chrome/browser/extensions/service_worker_apitest.cc [modify] https://crrev.com/1ed8de2cf4ca8f1c0597376ad57cf7f3a5616b8d/chrome/browser/notifications/notification_interactive_uitest_support.cc [modify] https://crrev.com/1ed8de2cf4ca8f1c0597376ad57cf7f3a5616b8d/chrome/browser/notifications/notification_interactive_uitest_support.h [modify] https://crrev.com/1ed8de2cf4ca8f1c0597376ad57cf7f3a5616b8d/chrome/browser/notifications/platform_notification_service_unittest.cc [modify] https://crrev.com/1ed8de2cf4ca8f1c0597376ad57cf7f3a5616b8d/chrome/common/chrome_features.cc
,
Apr 24 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Apr 24 2017