New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 714663 link

Starred by 1 user
Status: Fixed
Owner:
█ zakerinasab@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
█ junov@chromium.org
ccameron@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 634542


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Use correct color type with ColorBehavior::GlobalTargetColorSpace().ToSkColorSpace()

Project Member Reported by zakerinasab@chromium.org, Apr 24 2017 

When using ColorBehavior::GlobalTargetColorSpace().ToSkColorSpace() as
the color space of a SkImageInfo, the current code for color managed
canvas always uses kN32_SkColorType as the color type. Is this always
the correct thing to do? Or should we use kRGBA_F16_SkColorType if the global target profile is high bit depth?

If the latter is correct, we need a proper way to extract this from gfx::ColorSpace and then use the proper color type with
ColorBehavior::GlobalTargetColorSpace().ToSkColorSpace().
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c696ce2ea47777c4e06283142aa43f1833f9878

commit 1c696ce2ea47777c4e06283142aa43f1833f9878
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Wed Jun 14 14:50:46 2017

Use proper pixel format for GlobalTargetColorSpace

In CRC2D and ImageBitmap unit tests, 8888 pixel format is used where
ColorBehavior::GlobalTargetColorSpace().ToSkColorSpace() is called
to get the display color space. We should use fp16 wherever appropriate.

BUG:  714663 
Change-Id: I56e166480450adc9d41bc7d4c6b24496a8b015d6
Reviewed-on: https://chromium-review.googlesource.com/533723
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479380}
[modify] https://crrev.com/1c696ce2ea47777c4e06283142aa43f1833f9878/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp
[modify] https://crrev.com/1c696ce2ea47777c4e06283142aa43f1833f9878/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

Comment 2 by zakerinasab@chromium.org, Jun 14 2017

Status: Fixed (was: Assigned)

Comment 3 by zakerinasab@chromium.org, Nov 27 2017

Blocking: 634542
►

Sign in to add a comment