In BasseChildProcessConnection.java, mLock is not required anymore now that calls happen on the launcher thread. It should be removed.
Also we should cleanup ManagedChildProcessConnection.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93637728a91bf34e608f0c281febaf06af44fe30 commit 93637728a91bf34e608f0c281febaf06af44fe30 Author: jcivelli <jcivelli@chromium.org> Date: Fri Apr 28 05:18:33 2017 Making ChildProcessConnection only accessed from the launcher thread. As a result, removing locks and synchronizations. Also changing the way we store and report the OOM protected state. We now update the OOM protected state every time it changes as long as we are bound (that happens only on the launcher thread). When retrieving that OOM protected state (which happens on the IO thread), we return that state directly without the need of a lock. BUG= 714657 Review-Url: https://codereview.chromium.org/2840303002 Cr-Commit-Position: refs/heads/master@{#467892} [modify] https://crrev.com/93637728a91bf34e608f0c281febaf06af44fe30/content/public/android/java/src/org/chromium/content/browser/BaseChildProcessConnection.java [modify] https://crrev.com/93637728a91bf34e608f0c281febaf06af44fe30/content/public/android/java/src/org/chromium/content/browser/ManagedChildProcessConnection.java [modify] https://crrev.com/93637728a91bf34e608f0c281febaf06af44fe30/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java [modify] https://crrev.com/93637728a91bf34e608f0c281febaf06af44fe30/content/shell/android/BUILD.gn [modify] https://crrev.com/93637728a91bf34e608f0c281febaf06af44fe30/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java [add] https://crrev.com/93637728a91bf34e608f0c281febaf06af44fe30/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestUtils.java
Comment 1 by jcivelli@chromium.org
, Apr 25 2017